[MINOR] fix(docs): Modify the required value for the document security.md
#1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 20, 2023 11:16
This reverts commit 9a24880.
qqqttt123
commented
Dec 20, 2023
| | `gravitino.auxService.iceberg-rest.managerPassword` | Manager password to the key store. | (none) | Yes if use HTTPS | 0.3.0 | | ||
| | `gravitino.auxService.iceberg-rest.tlsProtocol` | TLS protocol to use. The JVM must support the TLS protocol to use. | (none) | Yes if use HTTPS | 0.3.0 | |
There was a problem hiding this comment.
This config option should be optional. I correct it by the way.
qqqttt123
commented
Dec 20, 2023
| | `gravitino.server.webserver.enableCipherAlgorithms` | The collection of enabled cipher algorithms. | `` | No | 0.3.0 | | ||
| | `gravitino.server.webserver.enableClientAuth` | Enables the authentication of the client. | `false` | No | 0.3.0 | | ||
| | `gravitino.server.webserver.trustStorePath` | Path to the trust store file. | (none) | Yes if use HTTPS and the authentication of client | 0.3.0 | | ||
| | `gravitino.server.webserver.trustStorePassword` | Password to the trust store. | (none) | Yes if use HTTPS and the authentication of client | 0.3.0 | |
There was a problem hiding this comment.
I missed (). I add it back by the way.
qqqttt123
commented
Dec 20, 2023
| | `gravitino.server.webserver.tlsProtocol` | TLS protocol to use. The JVM must support the TLS protocol to use. | (none) | No | 0.3.0 | | ||
| | `gravitino.server.webserver.enableCipherAlgorithms` | The collection of enabled cipher algorithms. | `` | No | 0.3.0 | | ||
| | `gravitino.server.webserver.enableClientAuth` | Enables the authentication of the client. | `false` | No | 0.3.0 | | ||
| | `gravitino.server.webserver.trustStorePath` | Path to the trust store file. | (none) | Yes if use HTTPS and the authentication of client | 0.3.0 | |
There was a problem hiding this comment.
I missed (). I add it back by the way.
qqqttt123
added
branch-0.3
need backport
jerryshao
approved these changes
Dec 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
…ty.md` (#1214) ### What changes were proposed in this pull request? Modify the required value for the document `security.md`. I modify some document mistakes by the way. ### Why are the changes needed? According the review #1191 (comment) , modify the required value. If a config option has a default value, this config option is not required. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need. --------- Co-authored-by: Heng Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the required value for the document
security.md.I modify some document mistakes by the way.
Why are the changes needed?
According the review #1191 (comment) , modify the required value. If a config option has a default value, this config option is not required.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.