Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1171] bugfix(postgresql): Fix bug where the same table name can be loaded under multiple schemas. #1183

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Clearvive
Copy link
Contributor

What changes were proposed in this pull request?

Fix a bug where the same table name can be loaded under multiple schemas

Why are the changes needed?

Fix: #1171

Does this PR introduce any user-facing change?

NO

How was this patch tested?

UT

@Clearvive Clearvive self-assigned this Dec 18, 2023
@Clearvive Clearvive force-pushed the 1171/bug-fix-pg-info branch from 2aa4174 to 7b47af4 Compare December 18, 2023 06:58
@Clearvive Clearvive changed the title [#846] docs(jdbc): add Jdbc catalog document. [#1171] bugfix(postgresql): Fix bug where the same table name can be loaded under multiple schemas. Dec 18, 2023
@Clearvive Clearvive requested a review from FANNG1 December 18, 2023 06:58
@Clearvive Clearvive marked this pull request as ready for review December 18, 2023 06:58
@Clearvive Clearvive added this to the Gravitino 0.4.0 milestone Dec 18, 2023
@FANNG1
Copy link
Contributor

FANNG1 commented Dec 18, 2023

I think we'd better use the metadata from JDBC driver not querying internal tables , as described in #994

@qqqttt123 qqqttt123 added branch-0.3 need backport Issues that need to backport to another branch labels Dec 18, 2023
@Clearvive Clearvive force-pushed the 1171/bug-fix-pg-info branch from f46a58b to 32f846e Compare December 18, 2023 07:21
@Clearvive
Copy link
Contributor Author

I think we'd better use the metadata from JDBC driver not querying internal tables , as described in #994

This PR will first fix a bug, and then consider modifying the logic of this part in the form of a future @FANNG1

@Clearvive Clearvive force-pushed the 1171/bug-fix-pg-info branch from 32f846e to 3cf66f0 Compare December 18, 2023 08:18
@jerryshao jerryshao merged commit dbdc1c9 into apache:main Dec 18, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
…loaded under multiple schemas. (#1183)

### What changes were proposed in this pull request?
Fix a bug where the same table name can be loaded under multiple schemas

### Why are the changes needed?
Fix: #1171 

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
UT

Co-authored-by: Clearvive <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] PostgreSQL query table information incorrect
4 participants