[#950] improvment(common): Add a method in ConfigEntry called create to support configurations with no default value #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate to support configurations with no default value
jerryshao
reviewed
Dec 20, 2023
| @@ -37,6 +37,7 @@ public class ConfigEntry<T> { | |||
| @Getter private boolean isDeprecated; | |||
|
|
|||
| private boolean isOptional; | |||
| private boolean isNoDefault; | |||
There was a problem hiding this comment.
Can we use another name, isNoDefault seems a bit awkward.
There was a problem hiding this comment.
How about hasNoDefault?
| * | ||
| * @return A new ConfigEntry instance with no default value. | ||
| */ | ||
| public ConfigEntry<T> createWithNoDefault() { |
There was a problem hiding this comment.
I think create is enough, no need to specify with "WithNoDefault".
| @@ -33,7 +33,7 @@ public interface OAuthConfig extends Configs { | |||
| .doc("The signing key of JWT when Gravitino uses OAuth as the authenticator") | |||
| .version("0.3.0") | |||
| .stringConf() | |||
| .createWithDefault(""); | |||
| .createWithNoDefault(); | |||
There was a problem hiding this comment.
Maybe you should check all the configs not only here, but also in each catalogs, to change them if there're no default value.
There was a problem hiding this comment.
OK. I will modify them at the same time.
jerryshao
approved these changes
Dec 20, 2023
|
@qqqttt123 can you please create a follow-up issue to address the validity of the value as we discussed offline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some configuration options are necessary but don't have default value.
Why are the changes needed?
Fix: #950
Does this PR introduce any user-facing change?
Change some configuration options from `` to none
How was this patch tested?
CI passed.