Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor topic commands in Gavitino CLI #6146

Closed
Tracked by #6138
justinmclean opened this issue Jan 8, 2025 · 3 comments · Fixed by #6174
Closed
Tracked by #6138

Refactor topic commands in Gavitino CLI #6146

justinmclean opened this issue Jan 8, 2025 · 3 comments · Fixed by #6174
Assignees
@Abyss-lord
Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers

Comments

@justinmclean
Copy link
Member

No description provided.

@justinmclean justinmclean mentioned this issue Jan 8, 2025
Open
13 tasks
@justinmclean justinmclean added the good first issue Good for newcomers label Jan 8, 2025
@Abyss-lord
Copy link
Contributor

@justinmclean Can I take on all the refactoring tasks and personally estimate that it will be completed in about a week. My concern is that most refactoring tasks are a good first issue and should be given to someone new？

@justinmclean
Copy link
Member Author

We can spread them about a bit. Feel free to do a couple or pick up ones nobody takes up.

@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 10, 2025
@Abyss-lord
[apache#6146] improve(CLI): Refactor topic commands in Gavitino CLI
34f3cb3 
Refactor topic commands in Gavitino CLI.
@Abyss-lord Abyss-lord mentioned this issue Jan 10, 2025
Merged
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 10, 2025
@Abyss-lord
[apache#6146] improve(CLI): Refactor topic commands in Gavitino CLI
db14365 
add license header to TopicCommandHandlers.java.
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Jan 10, 2025
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 11, 2025
@Abyss-lord
[apache#6146] improve(CLI): Refactor topic commands in Gavitino CLI (a…
87cfdf9 
…pache#6174)

### What changes were proposed in this pull request?

Refactor topic commands in Gavitino CLI

### Why are the changes needed?

Fix: apache#6146 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6146] improve(CLI): Refactor topic commands in Gavitino CLI Abyss-lord/gravitino
3 participants
@justinmclean @jerryshao @Abyss-lord