Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Refactor the validation logic of tag and role #6123

Closed
Tracked by #6083
Abyss-lord opened this issue Jan 6, 2025 · 1 comment · Fixed by #6127
Closed
Tracked by #6083

[Subtask] Refactor the validation logic of tag and role #6123

Abyss-lord opened this issue Jan 6, 2025 · 1 comment · Fixed by #6127
Assignees
@Abyss-lord
Labels
0.8.0 Release v0.8.0 subtask Subtasks of umbrella issue

Comments

@Abyss-lord
Copy link
Contributor

Describe the subtask

Refactor the validation logic of tag and role

Parent issue

parent: #6083
@Abyss-lord Abyss-lord added the subtask Subtasks of umbrella issue label Jan 6, 2025
@Abyss-lord Abyss-lord mentioned this issue Jan 6, 2025
Closed
7 tasks
@Abyss-lord
Copy link
Contributor Author

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 7, 2025
@Abyss-lord
[apache#6123] fix(CLI): Refactor the validation logic of tag and role
dbd50ec 
Refactor the validation logic of the Role and fix the test case.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 7, 2025
@Abyss-lord
[apache#6123] fix(CLI): Refactor the validation logic of tag and role
cd55663 
Refactor the validation logic of the Tag and fix the test case.
@Abyss-lord Abyss-lord mentioned this issue Jan 7, 2025
Merged
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 9, 2025
@Abyss-lord
[apache#6123] fix(CLI): Refactor the validation logic of tag and role (…
13973b3 
…apache#6127)

### What changes were proposed in this pull request?

Refactor the validation logic of the Tag and Role, meantime fix the test
case.

### Why are the changes needed?

Fix: apache#6123 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

ut + local test

**Role test**
```bash
gcli role grant -m demo_metalake --role admin
# Missing --privilege option.

gcli role revoke -m demo_metalake --role admin
# Missing --privilege option.
```

**Tag test**

```bash
gcli tag set -m demo_metalake 
# Missing --name option.

gcli tag set -m demo_metalake  --name catalog.schema.table --property property --tag tagA
# Missing --value option.

gcli tag set -m demo_metalake  --name catalog.schema.table --value value --tag tagA
# Missing --property option.

gcli tag remove -m demo_metalake --tag tagA
# Missing --name option.

gcli tag remove -m demo_metalake
# Missing --name option.

gcli tag delete -m demo_metalake
# Missing --tag option.

gcli tag create -m demo_metalake
# Missing --tag option.
```
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
0.8.0 Release v0.8.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6123] fix(CLI): Refactor the validation logic of tag and role Abyss-lord/gravitino
2 participants
@jerryshao @Abyss-lord