Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add check mechanism in CI to validate gradle publish #2655

Closed
yuqi1129 opened this issue Mar 22, 2024 · 0 comments · Fixed by #2718
Closed

[Improvement] Add check mechanism in CI to validate gradle publish #2655

yuqi1129 opened this issue Mar 22, 2024 · 0 comments · Fixed by #2718
Assignees
@yuqi1129
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 22, 2024 •
edited
Loading

What would you like to be improved?

Recently, several modifications have caused the publish task fail to work, we have fixed this twice(#2259, #2646) I believe it's necessary to introduce a mechanism to guarantee it.

How should we improve?

Adding the maven publish task in the CI pipeline may be a practical solution to this problem.
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Mar 22, 2024
@yuqi1129 yuqi1129 self-assigned this Mar 22, 2024
@yuqi1129 yuqi1129 mentioned this issue Mar 28, 2024
Merged
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 1, 2024
yuqi1129 added a commit that referenced this issue Apr 12, 2024
@yuqi1129
[#2655] improvement(CI): Add a step in CI pipeline to verify `gradle …
b1c5f65 
…publishToMavenLocal` (#2718)

### What changes were proposed in this pull request?

Add a new pipeline to test if `./gradlew publishToMavenLocal` works.

### Why are the changes needed?

Some changes may make `gradle publishToMavenLocal` can't work accidently
and we can't detect it currently.

Fix: #2655 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

N/A.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
2 participants
@jerryshao @yuqi1129