[Subtask] enable BadImport error-prone #2476
Comments
coolderli
added a commit
to coolderli/gravitino
that referenced
this issue
Apr 5, 2024
jerryshao
pushed a commit
that referenced
this issue
Apr 7, 2024
### What changes were proposed in this pull request? - enable BadImport error-prone - Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. ### Why are the changes needed? Fix: #2476 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - GitHub CI passed.
unknowntpo
pushed a commit
to unknowntpo/gravitino
that referenced
this issue
Apr 9, 2024
### What changes were proposed in this pull request? - enable BadImport error-prone - Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. ### Why are the changes needed? Fix: apache#2476 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - GitHub CI passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the subtask
enable BadImport error-prone
https://errorprone.info/bugpattern/BadImport
Parent issue
#2225
The text was updated successfully, but these errors were encountered: