Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] enable ClassCanBeStatic error-prone #2472

Closed
Tracked by #2225
coolderli opened this issue Mar 8, 2024 · 0 comments · Fixed by #2664
Closed
Tracked by #2225

[Subtask] enable ClassCanBeStatic error-prone #2472

coolderli opened this issue Mar 8, 2024 · 0 comments · Fixed by #2664
Labels
subtask Subtasks of umbrella issue

Comments

@coolderli
Copy link
Contributor

coolderli commented Mar 8, 2024

Describe the subtask

enable https://errorprone.info/bugpattern/ClassCanBeStatic error-prone:

https://errorprone.info/bugpattern/ClassCanBeStatic

Parent issue

#2225

@coolderli coolderli added the subtask Subtasks of umbrella issue label Mar 8, 2024
jerryshao pushed a commit that referenced this issue Mar 25, 2024
### What changes were proposed in this pull request?

- enable ClassCanBeStatic error-prone
- An inner class should be static unless it references members of its
enclosing class. See more details at
https://errorprone.info/bugpattern/ClassCanBeStatic

### Why are the changes needed?

Fix: #2472 

### Does this PR introduce _any_ user-facing change?
- no

### How was this patch tested?
- `./gradle build`
coolderli added a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
### What changes were proposed in this pull request?

- enable ClassCanBeStatic error-prone
- An inner class should be static unless it references members of its
enclosing class. See more details at
https://errorprone.info/bugpattern/ClassCanBeStatic

### Why are the changes needed?

Fix: apache#2472 

### Does this PR introduce _any_ user-facing change?
- no

### How was this patch tested?
- `./gradle build`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask Subtasks of umbrella issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant