Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Update metalake error in the web UI #1391

Closed
ch3yne opened this issue Jan 9, 2024 · 0 comments · Fixed by #1394
Closed

[Bug report] Update metalake error in the web UI #1391

ch3yne opened this issue Jan 9, 2024 · 0 comments · Fixed by #1394
Assignees
@ch3yne

Comments

@ch3yne
Copy link
Contributor

ch3yne commented Jan 9, 2024

Describe what's wrong

Click the Update metalake icon button return error in the web UI

Error message and/or stacktrace

Unhandled Runtime Error
TypeError: Cannot convert undefined or null to object

Call Stack
Function.keys

eval
file:///Users/cheyne/workspace/datastrato/github/ch3yne/gravitino/web/dist/static/chunks/6db81e..js (124:37)
commitHookEffectListMount
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (20998:23)
commitHookPassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23051:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23156:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23267:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)
commitPassiveMountOnFiber
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23154:8)
recursivelyTraversePassiveMountEffects
node_modules/next/dist/compiled/react-dom/cjs/react-dom.development.js (23134:6)

How to reproduce

  1. Click the update metalake button

Additional context

No response
@ch3yne ch3yne self-assigned this Jan 9, 2024
@ch3yne ch3yne mentioned this issue Jan 9, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 9, 2024
@ch3yne
[#1391] fix(UI): Fix update metalake error in the web UI (#1394)
a0732b8 
### What changes were proposed in this pull request?

Fix update metalake error in the web UI.

The reason for the error is that the existing metalake is not set with
`properties`, causing an error unable to find properties when
deconstructing the `properties` of metalake.

The solution is to set an empty object to the `properties`.

1. existed metalake without `properties`
<img width="389" alt="no-props"
src="https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035">

2. click `update metalake` icon button, and now the update pop-up will
display correctly.
<img width="596" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023">



### Why are the changes needed?

Fix: #1391
Fix: #1397

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue Jan 9, 2024
@ch3yne @web-flow
[#1391] fix(UI): Fix update metalake error in the web UI (#1394)
9babb96 
### What changes were proposed in this pull request?

Fix update metalake error in the web UI.

The reason for the error is that the existing metalake is not set with
`properties`, causing an error unable to find properties when
deconstructing the `properties` of metalake.

The solution is to set an empty object to the `properties`.

1. existed metalake without `properties`
<img width="389" alt="no-props"
src="https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035">

2. click `update metalake` icon button, and now the update pop-up will
display correctly.
<img width="596" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023">



### Why are the changes needed?

Fix: #1391
Fix: #1397

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao mentioned this issue Jan 9, 2024
Merged
yuqi1129 pushed a commit that referenced this issue Jan 9, 2024
@jerryshao @ch3yne
[#1391] fix(UI): Fix update metalake error in the web UI (#1400)
5ae3302 
### What changes were proposed in this pull request?

Fix update metalake error in the web UI.

The reason for the error is that the existing metalake is not set with
`properties`, causing an error unable to find properties when
deconstructing the `properties` of metalake.

The solution is to set an empty object to the `properties`.

1. existed metalake without `properties`
<img width="389" alt="no-props"
src="https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035">

2. click `update metalake` icon button, and now the update pop-up will
display correctly.
<img width="596" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023">



### Why are the changes needed?

Fix: #1391
Fix: #1397

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1391] fix(UI): Fix update metalake error in the web UI ch3yne/gravitino
1 participant
@ch3yne