-
Notifications
You must be signed in to change notification settings - Fork 383
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### What changes were proposed in this pull request? The Gravitino command line class is a little large and could be broken up. ### Why are the changes needed? For readability and maintainability. Fix: #6139 ### Does this PR introduce _any_ user-facing change? None. ### How was this patch tested? Tested locally. --------- Co-authored-by: Shaofeng Shi <[email protected]>
- Loading branch information
1 parent
e4151e9
commit 08f47ad
Showing
2 changed files
with
202 additions
and
86 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201 changes: 201 additions & 0 deletions
201
clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.cli; | ||
|
|
||
| import org.apache.commons.cli.CommandLine; | ||
| import org.apache.gravitino.cli.commands.Command; | ||
|
|
||
| /** | ||
| * Handles the command execution for Metalakes based on command type and the command line options. | ||
| */ | ||
| public class MetalakeCommandHandler extends CommandHandler { | ||
|
|
||
| private final GravitinoCommandLine gravitinoCommandLine; | ||
| private final CommandLine line; | ||
| private final String command; | ||
| private final boolean ignore; | ||
| private final String url; | ||
| private String metalake; | ||
|
|
||
| /** | ||
| * Constructs a MetalakeCommandHandler instance. | ||
| * | ||
| * @param gravitinoCommandLine The Gravitino command line instance. | ||
| * @param line The command line arguments. | ||
| * @param command The command to execute. | ||
| * @param ignore Ignore server version mismatch. | ||
| */ | ||
| public MetalakeCommandHandler( | ||
| GravitinoCommandLine gravitinoCommandLine, CommandLine line, String command, boolean ignore) { | ||
| this.gravitinoCommandLine = gravitinoCommandLine; | ||
| this.line = line; | ||
| this.command = command; | ||
| this.ignore = ignore; | ||
| this.url = getUrl(line); | ||
| } | ||
|
|
||
| /** Handles the command execution logic based on the provided command. */ | ||
| public void handle() { | ||
| String userName = line.getOptionValue(GravitinoOptions.LOGIN); | ||
| FullName name = new FullName(line); | ||
| Command.setAuthenticationMode(getAuth(line), userName); | ||
|
|
||
| if (CommandActions.LIST.equals(command)) { | ||
| handleListCommand(); | ||
| return; | ||
| } | ||
|
|
||
| metalake = name.getMetalakeName(); | ||
|
|
||
| if (!executeCommand()) { | ||
| System.err.println(ErrorMessages.UNSUPPORTED_COMMAND); | ||
| Main.exit(-1); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Executes the specific command based on the command type. | ||
| * | ||
| * @return true if the command is supported, false otherwise | ||
| */ | ||
| private boolean executeCommand() { | ||
| switch (command) { | ||
| case CommandActions.DETAILS: | ||
| handleDetailsCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.CREATE: | ||
| handleCreateCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.DELETE: | ||
| handleDeleteCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.SET: | ||
| handleSetCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.REMOVE: | ||
| handleRemoveCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.PROPERTIES: | ||
| handlePropertiesCommand(); | ||
| return true; | ||
|
|
||
| case CommandActions.UPDATE: | ||
| handleUpdateCommand(); | ||
| return true; | ||
|
|
||
| default: | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| /** Handles the "LIST" command. */ | ||
| private void handleListCommand() { | ||
| String outputFormat = line.getOptionValue(GravitinoOptions.OUTPUT); | ||
| gravitinoCommandLine.newListMetalakes(url, ignore, outputFormat).validate().handle(); | ||
| } | ||
|
|
||
| /** Handles the "DETAILS" command. */ | ||
| private void handleDetailsCommand() { | ||
| if (line.hasOption(GravitinoOptions.AUDIT)) { | ||
| gravitinoCommandLine.newMetalakeAudit(url, ignore, metalake).validate().handle(); | ||
| } else { | ||
| String outputFormat = line.getOptionValue(GravitinoOptions.OUTPUT); | ||
| gravitinoCommandLine | ||
| .newMetalakeDetails(url, ignore, outputFormat, metalake) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
| } | ||
|
|
||
| /** Handles the "CREATE" command. */ | ||
| private void handleCreateCommand() { | ||
| String comment = line.getOptionValue(GravitinoOptions.COMMENT); | ||
| gravitinoCommandLine.newCreateMetalake(url, ignore, metalake, comment).validate().handle(); | ||
| } | ||
|
|
||
| /** Handles the "DELETE" command. */ | ||
| private void handleDeleteCommand() { | ||
| boolean force = line.hasOption(GravitinoOptions.FORCE); | ||
| gravitinoCommandLine.newDeleteMetalake(url, ignore, force, metalake).validate().handle(); | ||
| } | ||
|
|
||
| /** Handles the "SET" command. */ | ||
| private void handleSetCommand() { | ||
| String property = line.getOptionValue(GravitinoOptions.PROPERTY); | ||
| String value = line.getOptionValue(GravitinoOptions.VALUE); | ||
| gravitinoCommandLine | ||
| .newSetMetalakeProperty(url, ignore, metalake, property, value) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
|
|
||
| /** Handles the "REMOVE" command. */ | ||
| private void handleRemoveCommand() { | ||
| String property = line.getOptionValue(GravitinoOptions.PROPERTY); | ||
| gravitinoCommandLine | ||
| .newRemoveMetalakeProperty(url, ignore, metalake, property) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
|
|
||
| /** Handles the "PROPERTIES" command. */ | ||
| private void handlePropertiesCommand() { | ||
| gravitinoCommandLine.newListMetalakeProperties(url, ignore, metalake).validate().handle(); | ||
| } | ||
|
|
||
| /** Handles the "UPDATE" command. */ | ||
| private void handleUpdateCommand() { | ||
| if (line.hasOption(GravitinoOptions.ENABLE) && line.hasOption(GravitinoOptions.DISABLE)) { | ||
| System.err.println(ErrorMessages.INVALID_ENABLE_DISABLE); | ||
| Main.exit(-1); | ||
| } | ||
| if (line.hasOption(GravitinoOptions.ENABLE)) { | ||
| boolean enableAllCatalogs = line.hasOption(GravitinoOptions.ALL); | ||
| gravitinoCommandLine | ||
| .newMetalakeEnable(url, ignore, metalake, enableAllCatalogs) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
| if (line.hasOption(GravitinoOptions.DISABLE)) { | ||
| gravitinoCommandLine.newMetalakeDisable(url, ignore, metalake).validate().handle(); | ||
| } | ||
|
|
||
| if (line.hasOption(GravitinoOptions.COMMENT)) { | ||
| String comment = line.getOptionValue(GravitinoOptions.COMMENT); | ||
| gravitinoCommandLine | ||
| .newUpdateMetalakeComment(url, ignore, metalake, comment) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
| if (line.hasOption(GravitinoOptions.RENAME)) { | ||
| String newName = line.getOptionValue(GravitinoOptions.RENAME); | ||
| boolean force = line.hasOption(GravitinoOptions.FORCE); | ||
| gravitinoCommandLine | ||
| .newUpdateMetalakeName(url, ignore, force, metalake, newName) | ||
| .validate() | ||
| .handle(); | ||
| } | ||
| } | ||
| } |