Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOBBLIN-1809] Add new lookback version finder for use with iceberg retention #3670

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[GOBBLIN-1809] Add new lookback version finder for use with iceberg retention #3670

merged 1 commit into from
Apr 11, 2023

Conversation

jack-moseley
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Add new version finder which does not actually list filepaths, and just constructs all unique path names/versions for a given lookback time with a given path partition pattern. This is useful for example with the iceberg cleanable datasets, which if decoupled from data files, should not depend on existence of the file path.

Also fixed a bug in DatasetCleaner which sometimes causes the job to fail during shutdown and not print the actual issue with the job.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added unit test and tested in retention job

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

homatthew
homatthew approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@homatthew homatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and questions. Seems like a reasonable implementation with good tests

@jack-moseley jack-moseley force-pushed the lookback-version-finder branch from 903a25e to 410c9be Compare April 11, 2023 22:09
homatthew
homatthew approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@homatthew homatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3670 (comment)

Latest iteration looks good. The above discussion shows the performance impact of this change (or general lack thereof)

@jack-moseley jack-moseley force-pushed the lookback-version-finder branch from 410c9be to b7b97c7 Compare April 11, 2023 22:12
@Will-Lo Will-Lo merged commit c50b527 into apache:master Apr 11, 2023
wsarecv pushed a commit to wsarecv/gobblin that referenced this pull request Apr 11, 2023
@jack-moseley
Add new lookback version finder for use with iceberg retention (apach…
b6bd9b8 
…e#3670)
phet added a commit to phet/gobblin that referenced this pull request Aug 15, 2023
@phet
Merge remote-tracking branch 'upstream/master'
90dd1ff 
* upstream/master:
  [GOBBLIN-1832] Emit warning instead of failing job for retention of Hive Table Views (apache#3695)
  [GOBBLIN-1831] Use flowexecutionid in kafka monitor and jobnames (apache#3694)
  [GOBBLIN-1824]Improving the Efficiency of Work Planning in Manifest-Based DistCp Jobs (apache#3686)
  [GOBBLIN-1829] Fixes bug where the wrong workunit event was being tracked for keepin… (apache#3691)
  [GOBBLIN-1828] Implement Timeout for Creating Writer Functionality (apache#3690)
  [GOBBLIN-1827] Add check that if nested field is optional and has a non-null default… (apache#3689)
  [GOBBLIN-1826] Change isAssignableFrom() to isSuperTypeOf() per Guava 20 javadocs to… (apache#3688)
  [GOBBLIN-1822]Logging Abnormal Helix Task States (apache#3685)
  [GOBBLIN-1819] Log helix workflow information and timeout information during submission wait / polling (apache#3681)
  [GOBBLIN-1821] Let flow execution ID propagate to the Job ID if it exists (apache#3684)
  [GOBBLIN-1810] Support general iceberg catalog (support configurable behavior for metadata retention policy) (apache#3680)
  Add null default value to observability events that are additionally added (apache#3682)
  [GOBBLIN-1816] Add job properties and GaaS instance ID to observability event (apache#3676)
  [GOBBLIN-1785] add MR_JARS_BASE_DIR and logic to delete old mr jar dirs (apache#3642)
  initiliaze yarn clients in yarn app launcher so that a child class can override the yarn client creation logic (apache#3679)
  [GOBBLIN-1811]Fix Iceberg Registration Serialization (apache#3673)
  [GOBBLIN-1817] change some deprecated code and fix minor codestyle (apache#3678)
  [GOBBLIN-1812] Mockito should only be test compile (apache#3674)
  [GOBBLIN-1813] Helix workflows submission timeouts are configurable (apache#3677)
  [GOBBLIN-1810] Support general iceberg catalog in icebergMetadataWriter (apache#3672)
  Refactor yarn app launchers to support extending these classes (apache#3671)
  [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0 (apache#3669)
  [GOBBLIN-1806] Submit dataset summary event post commit and integrate them into GaaSObservabilityEvent (apache#3667)
  [GOBBLIN-1814] Add `MRJobLauncher` configurability for any failing mapper to be fatal to the MR job (apache#3675)
  Add new lookback version finder for use with iceberg retention (apache#3670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Will-Lo Will-Lo Will-Lo approved these changes

@homatthew homatthew homatthew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-moseley @Will-Lo @homatthew