Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1777] Register gauge metrics for change monitors #3634

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

umustafi
Copy link
Contributor

@umustafi umustafi commented Feb 2, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Unlike other metrics gauges need to be registered. Quick fix to this.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

Codecov Report

Merging #3634 (75be6dd) into master (667d797) will decrease coverage by 10.51%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #3634       +/-   ##
=============================================
- Coverage     46.56%   36.06%   -10.51%     
+ Complexity    10666     1480     -9186     
=============================================
  Files          2133      382     -1751     
  Lines         83541    15646    -67895     
  Branches       9288     1547     -7741     
=============================================
- Hits          38905     5642    -33263     
+ Misses        41074     9546    -31528     
+ Partials       3562      458     -3104     
Impacted Files Coverage Δ
...ervice/monitoring/DagActionStoreChangeMonitor.java
...lin/service/monitoring/SpecStoreChangeMonitor.java
...lin/metastore/MysqlJobStatusStateStoreFactory.java
.../mapreduce/orc/OrcValueCombineFileInputFormat.java
...che/gobblin/writer/HiveWritableHdfsDataWriter.java
...n/java/org/apache/gobblin/salesforce/SfConfig.java
...blin/runtime/std/FilteredJobLifecycleListener.java
...bblin/password/EncryptedPasswordAuthenticator.java
...ker/task/TaskLevelPolicyCheckerBuilderFactory.java
...e/modules/orchestration/MysqlUserQuotaManager.java
... and 1742 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Will-Lo Will-Lo changed the title Register gauge metrics for change monitors [GOBBLIN-1777] Register gauge metrics for change monitors Feb 2, 2023
@Will-Lo Will-Lo merged commit 9f8ab24 into apache:master Feb 2, 2023
@umustafi umustafi deleted the registerGauge branch February 2, 2023 19:30
umustafi added a commit to umustafi/gobblin that referenced this pull request Feb 8, 2023
phet added a commit to phet/gobblin that referenced this pull request Feb 13, 2023
* upstream/master:
  [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632)
  [GOBBLIN-1773] Fix bugs in quota manager (apache#3636)
  [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639)
  [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616)
  [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637)
  [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635)
  Register gauge metrics for change monitors (apache#3634)
phet added a commit to phet/gobblin that referenced this pull request Mar 24, 2023
* upstream/master:
  [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632)
  [GOBBLIN-1773] Fix bugs in quota manager (apache#3636)
  [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639)
  [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616)
  [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637)
  [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635)
  Register gauge metrics for change monitors (apache#3634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants