Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOBBLIN-1768] Fix constructor in KafkaJobStatusMonitorFactory so that it can be inj… #3628

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[GOBBLIN-1768] Fix constructor in KafkaJobStatusMonitorFactory so that it can be inj… #3628

merged 1 commit into from
Jan 23, 2023

Conversation

Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented Jan 23, 2023

…ected

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

There is a bug in the KafkaJobStatusMonitorFactory that prevents it from being initialized due to a runtime bug with Guice dependencies. This PR fixes that issue by fixing the injected constructor.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Will-Lo Will-Lo merged commit 3dd0657 into apache:master Jan 23, 2023
phet added a commit to phet/gobblin that referenced this pull request Feb 13, 2023
@phet
Merge remote-tracking branch 'upstream/master'
d2338dd 
* upstream/master:
  [GOBBLIN-1771] Clean up logs for dataset commit and file cleanup (apache#3631)
  [GOBBLIN-1770] Allow null values for fields in GaaSObservabilityEvent.Issue fields which are optional
  [GOBBLIN-1769] Change a noisy log that indicates that the queue capacity is almost full to debug (apache#3629)
  [GOBBLIN-1766] Define metric to measure lag from producing to consume… (apache#3625)
  [GOBBLIN-1765] Add support to sync metadata for dir in manifest based copy (apache#3624)
  [GOBBLIN-1768] Fix constructor in KafkaJobStatusMonitorFactory so that it can be injected (apache#3628)
  Specifically name each Hikari connection pool created, for traceability (apache#3627)
@Will-Lo Will-Lo deleted the fix-bug-gaas-kafka-jobstatus-inject branch September 26, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umustafi umustafi umustafi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Will-Lo @umustafi