Log other errors and throw 500

apache · Jul 21, 2022 · d7e92ea · d7e92ea
1 parent 1aaf86a
commit d7e92ea
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...rvice-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java b/...rvice-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java
@@ -140,6 +140,8 @@ public CreateResponse createFlowConfig(FlowConfig flowConfig, boolean triggerLis
         throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE, e.getMessage());
       } catch (Throwable e) {
         // TODO: Compilation errors should fall under throwable exceptions as well instead of checking for strings
+        log.warn(String.format("Failed to add flow configuration %s.%s to catalog due to", flowConfig.getId().getFlowGroup(), flowConfig.getId().getFlowName()), e);
+        throw new RestLiServiceException(HttpStatus.S_500_INTERNAL_SERVER_ERROR, e.getMessage());
       }
       return new CreateResponse(new ComplexResourceKey<>(flowConfig.getId(), new EmptyRecord()), HttpStatus.S_201_CREATED);
     }
@@ -181,6 +183,8 @@ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig, boo
       throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE, e.getMessage());
     } catch (Throwable e) {
       // TODO: Compilation errors should fall under throwable exceptions as well instead of checking for strings
+      log.warn(String.format("Failed to add flow configuration %s.%sto catalog due to", flowId.getFlowGroup(), flowId.getFlowName()), e);
+      throw new RestLiServiceException(HttpStatus.S_500_INTERNAL_SERVER_ERROR, e.getMessage());
     }
     return new UpdateResponse(HttpStatus.S_200_OK);
   }

diff --git a/...ice-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java b/...ice-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java
@@ -85,8 +85,10 @@ public CreateKVResponse createFlowConfig(FlowConfig flowConfig, boolean triggerL
       responseMap = this.flowCatalog.put(flowSpec, triggerListener);
     } catch (QuotaExceededException e) {
         throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE, e.getMessage());
-      } catch (Throwable e) {
+    } catch (Throwable e) {
       // TODO: Compilation errors should fall under throwable exceptions as well instead of checking for strings
+      log.warn(String.format("Failed to add flow configuration %s.%s to catalog due to", flowConfig.getId().getFlowGroup(), flowConfig.getId().getFlowName()), e);
+      throw new RestLiServiceException(HttpStatus.S_500_INTERNAL_SERVER_ERROR, e.getMessage());
     }
     HttpStatus httpStatus;