feat(java): support meta compression by Deflater #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| byte[] compressed = | ||
| classResolver | ||
| .getFury() |
There was a problem hiding this comment.
I had an idea when I was looking at the code recently.
Could org.apache.fury.config.Config be set to org.apache.fury.resolver.SerializationContext?
I think it is more reasonable to get Config from SerializationContext during runtime. It feels a bit weird to get it from Fury object.
This will reduce the burden on the Fury class.
There was a problem hiding this comment.
Good suggestion, I like the idea to get config from context. But other get context, user must get fury first, then get config from context. It will introduce an extra indirection
There was a problem hiding this comment.
I think it's not related to this PR, we can discuss it in another issue
java/fury-core/src/main/java/org/apache/fury/config/FuryBuilder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR support meta compression and add Deflater as default compressor.
In our test, it can compress meta by reduce size of 243 without introducing any performance cost:
Related issues
#1660
Does this PR introduce any user-facing change?
Benchmark