[FLINK-36067][runtime] Support optimize stream graph based on input info. #25790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunRuiLee
force-pushed
the
FLINK-36067-1212
branch
3 times, most recently
from
9d3e01f to
9b2cc2a
Compare
davidradl
reviewed
Dec 12, 2024
| @@ -273,6 +273,16 @@ public void onNewJobVerticesAdded(List<JobVertex> newVertices, int pendingOperat | |||
|
|
|||
| // 4. update json plan | |||
| getExecutionGraph().setJsonPlan(JsonPlanGenerator.generatePlan(getJobGraph())); | |||
|
|
|||
| // 5. update the DistributionPattern of the upstream results consumed by the newly created | |||
| // JobVertex and aggregate subpartition bytes. | |||
There was a problem hiding this comment.
aggregate subpartition bytes. -> aggregate subpartition bytes when possible.
I would find is useful to describe in more detail was aggregate subpartition bytes means and why we can perform this optimization in some circumstances.
davidradl
reviewed
Dec 12, 2024
| @@ -937,6 +965,26 @@ SpeculativeExecutionHandler getSpeculativeExecutionHandler() { | |||
| return speculativeExecutionHandler; | |||
| } | |||
|
|
|||
| private void tryUpdateResultInfo(IntermediateDataSetID id, DistributionPattern targetPattern) { | |||
There was a problem hiding this comment.
could you add some comments detailing the algorithm and its benefits.
…OptimizationStrategy
…artition info when all consumers created and initialized.
JunRuiLee
force-pushed
the
FLINK-36067-1212
branch
from
9b2cc2a to
ecc3183
Compare
davidradl
reviewed
Dec 12, 2024
| @@ -207,6 +210,10 @@ public boolean isForward() { | |||
| return intermediateDataSet.isForward(); | |||
| } | |||
|
|
|||
| public boolean isEveryConsumerConsumeAllSubPartitions() { | |||
There was a problem hiding this comment.
I am confused by why this method is checking broadcasts - how does this relate to downstream consumers being able to consume the subpartitions
davidradl
reviewed
Dec 12, 2024
| @@ -35,6 +35,14 @@ public interface IntermediateResultInfo { | |||
| */ | |||
| boolean isBroadcast(); | |||
|
|
|||
| /** | |||
| * Indicates whether every downstream consumer needs to consume all produced sub-partitions. | |||
There was a problem hiding this comment.
I see this method seems to be relate to broadcasts - it would be good to explain how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-36067][runtime] Support optimize stream graph based on input info.
Brief change log
Verifying this change
This change added tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation