[FLINK-36876] Support external eventLoopGroup for RestClient #25788
+70
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Dec 11, 2024
| @@ -143,30 +144,42 @@ public class RestClient implements AutoCloseableAsync { | |||
| ConcurrentHashMap.newKeySet(); | |||
|
|
|||
| private final List<OutboundChannelHandlerFactory> outboundChannelHandlerFactories; | |||
| private final Boolean useInternalEventLoopGroup; | |||
There was a problem hiding this comment.
nit: why not boolean, I assume we do not want this ever to be null
davidradl
reviewed
Dec 12, 2024
| } | ||
|
|
||
| private RestClusterClient( | ||
| Configuration configuration, | ||
| @Nullable RestClient restClient, | ||
| T clusterId, | ||
| WaitStrategy waitStrategy, | ||
| ClientHighAvailabilityServicesFactory clientHAServicesFactory) | ||
| ClientHighAvailabilityServicesFactory clientHAServicesFactory, | ||
| EventLoopGroup group) |
There was a problem hiding this comment.
should we tag with @nullable?
davidradl
reviewed
Dec 12, 2024
| selectStrategyFactory); | ||
| useInternalEventLoopGroup = true; | ||
| } else { | ||
| useInternalEventLoopGroup = false; |
There was a problem hiding this comment.
should we check that the supplied group is not shutting down or shutdown
There was a problem hiding this comment.
I see the channel is NioSocketChannel.class is this always the case for external groups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support external eventLoopGroup for RestClient
Brief change log
Verifying this change
The change is tested by RestClientTest.testExternalEventGroup
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation