Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API #25765

Closed
wants to merge 2 commits into from

Conversation

Au-Miner
Copy link

@Au-Miner Au-Miner commented Dec 9, 2024

What is the purpose of the change

Introduce TemporalProcessTimeJoinOperator in TemporalJoin with async state api.

Brief change log

  • Introduce TemporalProcessTimeJoinOperator in TemporalJoin with async state api.
  • Add TemporalProcessTimeJoinOperatorTest and TemporalJoinITCase

Verifying this change

Existent tests and new added tests can verify this change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@Au-Miner Au-Miner marked this pull request as ready for review December 9, 2024 12:53
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 9, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Au-Miner Au-Miner closed this by deleting the head repository Dec 10, 2024
minRetentionTime,
maxRetentionTime,
isLeftOuterJoin);
if (config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a heads up, changes like this should update consumedOptions for the JSON serialization.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review. Due to a change in the warehouse path, the PR has been resubmitted #25777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants