Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36848][table] Remove FlinkLimit0RemoveRule #25742

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

liuyongvs
Copy link
Contributor

What is the purpose of the change

A bit reasoning for the change
high calcite version has fixed, current calcite version is 1.34

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 5, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs liuyongvs force-pushed the replace_FlinkLimit0RemoveRule branch from f35b91e to 310bc71 Compare December 5, 2024 08:18
@liuyongvs
Copy link
Contributor Author

hi @snuyanzin will you help review this pr?

@davidradl
Copy link
Contributor

Reviewed by Chi on 05/12/24 Need a committer to review.

@liuyongvs liuyongvs requested a review from snuyanzin December 9, 2024 02:04
@liuyongvs
Copy link
Contributor Author

hi @snuyanzin i have addressed your review.

@snuyanzin snuyanzin merged commit 22398b4 into apache:master Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants