[FLINK-34702][table-planner] Refactor Deduplicate optimization to defer to StreamPhysicalRank for valid StreamExecDeduplicate node conversion to avoid exceptions #25380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
reviewed
Sep 24, 2024
| * Stream physical RelNode which deduplicate on keys and keeps only first row or last row. This node | ||
| * is an optimization of [[StreamPhysicalRank]] for some special cases. Compared to | ||
| * [[StreamPhysicalRank]], this node could use mini-batch and access less state. | ||
| * TODO to be removed after FLINK-34702 is fixed. Stream physical RelNode which deduplicate on keys |
There was a problem hiding this comment.
Since this operator may be used in existing Flink jobs, I do not believe we can remove it.
There was a problem hiding this comment.
The StreamPhysicalDeduplicate is just an intermediate node in the optimization process, after all the optimizations are done it will be converted to StreamExecDeduplicate and eventually to the actual runtime sql duplicate operator.
Also, the compiled plan does not depend on the physical node, but on the exec node. Therefore, it does not affect existing sql jobs.
lincoln-lil
force-pushed
the
FLINK-34702
branch
from
55d423f to
5b795a3
Compare
lincoln-lil
changed the title
lincoln-lil
commented
Sep 25, 2024
.../flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RankUtil.scala
Outdated
Show resolved
Hide resolved
liuyongvs
approved these changes
Sep 25, 2024
.../org/apache/flink/table/planner/plan/rules/logical/TemporalJoinRewriteWithUniqueKeyRule.java
Outdated
Show resolved
Hide resolved
| @@ -321,7 +321,7 @@ Calc(select=[amount, currency, rowtime, PROCTIME_MATERIALIZE(proctime) AS procti | |||
| : +- Calc(select=[amount, currency, rowtime, PROCTIME() AS proctime], changelogMode=[I]) | |||
| : +- LegacyTableSourceScan(table=[[default_catalog, default_database, Orders, source: [CollectionTableSource(amount, currency, rowtime)]]], fields=[amount, currency, rowtime], changelogMode=[I]) | |||
There was a problem hiding this comment.
the physical plan looks good to me and the exec plan is not changed +1
|
LGTM, only left one minor comment |
…d instead decide to perform exec node transformations in StreamPhysicalRank
…inkChangelogModeInferenceProgram and StreamNonDeterministicUpdatePlanVisitor
…inkRelMdColumnUniqueness
…inkRelMdUniqueKeys
…inkRelMdModifiedMonotonicity
…inkRelMdUpsertKeys
lincoln-lil
force-pushed
the
FLINK-34702
branch
from
75391b0 to
96f0dba
Compare
Thank you for reviewing this! I've rebased the latest master and will merge it after ci green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A refactor to avoid using StreamPhysicalDeduplicate and instead decide to perform exec node transformations in StreamPhysicalRank, so that we can completely avoid Exception "StreamPhysicalDeduplicate doesn't support consuming update changes..." for various queries.
Brief change log
Delay the rank/dedup transformation to physical -> exec phase
Verifying this change
Streaming Rank/DedupTest and newly added test cases
Does this pull request potentially affect one of the following parts:
Documentation