Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-29436][FLINK-33359] Upgrade spotless to 2.27.1 to support jdk17 #690

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[FLINK-29436][FLINK-33359] Upgrade spotless to 2.27.1 to support jdk17 #690

merged 1 commit into from
Oct 25, 2023

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

the blockers for using it with jdk17 are fixed at diffplug/spotless#1224 and diffplug/spotless#1228.

This allows to run spotless for kubernetes operator

Brief change log

pom.xml

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changes to the CustomResourceDescriptors: ( no)
  • Core observer or reconciler logic that is regularly executed: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

1996fanrui
1996fanrui approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snuyanzin for the contribution!

LGTM.

@1996fanrui 1996fanrui requested a review from gyfora October 25, 2023 15:01
@snuyanzin
Copy link
Contributor Author

Thanks for taking a look

@snuyanzin snuyanzin merged commit d0ee0e9 into apache:main Oct 25, 2023
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1996fanrui 1996fanrui 1996fanrui approved these changes

@gyfora gyfora gyfora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snuyanzin @gyfora @1996fanrui