Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37300][common] Add RawDataType to represent the type in data sources #3923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

whhe
Copy link
Member

@whhe whhe commented Feb 18, 2025

This closes FLINK-37300.

In this PR, I added RawDataType and JdbcRawDataType to represent the original data type in data sources, and made some changes to the base DataType class:

  1. Added a new copy method copy(boolean isNullable, RawDataType rawDataType), all external calls to copy method should use it directly or indirectly.
  2. Added a new toString method asSerializableStringWithRawDataType, asSummaryString will change to use it by default.
  3. To avoid incorrect calls to the original copy(boolean isNullable) and asSerializableString method, I changed them to protected.

@whhe whhe force-pushed the datatype branch 3 times, most recently from 576e7b2 to 998b45b Compare February 24, 2025 03:34
@whhe whhe force-pushed the datatype branch 3 times, most recently from 156bf68 to 4771480 Compare March 4, 2025 08:48
@whhe whhe force-pushed the datatype branch 2 times, most recently from 3e9e2f1 to 068fc71 Compare March 4, 2025 11:51
@github-actions github-actions bot removed the e2e-tests label Mar 5, 2025
@whhe
Copy link
Member Author

whhe commented Mar 5, 2025

Many test cases are modified because the newly added rawDataType field in DataType class, and now these test cases generally pass. PTAL @leonardBang @yuxiqian

@leonardBang
Copy link
Contributor

ok,nice work @whhe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants