[mysql] Support tables which do not contain a primary key (#1827) #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstraw
reviewed
May 26, 2023
...ctor-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/utils/ChunkUtils.java
Outdated
Show resolved
Hide resolved
...dc/src/main/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlChunkSplitter.java
Outdated
Show resolved
Hide resolved
leonardBang
reviewed
May 29, 2023
There was a problem hiding this comment.
Thanks @ruanhang1993 for the contribution, I left some comments.
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java
Outdated
Show resolved
Hide resolved
...dc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/SnapshotSplitReader.java
Outdated
Show resolved
Hide resolved
...or-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/MySqlSourceBuilder.java
Outdated
Show resolved
Hide resolved
...tor-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/utils/RecordUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/ververica/cdc/connectors/mysql/source/config/MySqlSourceConfigFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: zhuyuan03 <[email protected]>
leonardBang
reviewed
May 29, 2023
...ctor-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/utils/ChunkUtils.java
Outdated
Show resolved
Hide resolved
...ysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java
Outdated
Show resolved
Hide resolved
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java
Outdated
Show resolved
Hide resolved
...tor-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/utils/RecordUtils.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
May 30, 2023
| if (isDelete) { | ||
| if (records == null || records.isEmpty()) { | ||
| LOG.error( | ||
| "Deleting a record which is not in its split for tables without primary keys. This may happen when the chunk key column is updated in another snapshot split."); |
There was a problem hiding this comment.
we need open a doc PR to guide user how to choose chunk key column
There was a problem hiding this comment.
I will provide the docs about these experimental features later. See #2164.
Hi, @zstraw . I will provide the docs about these experimental features. |
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
Co-authored-by: zhuyuan03 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1827.