Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go SDK for EventMesh gRPC #911

Merged
merged 47 commits into from
Jun 7, 2022
Merged

Go SDK for EventMesh gRPC #911

merged 47 commits into from
Jun 7, 2022

Conversation

walleliu1016
Copy link
Contributor

merge the golang sdk to master branch

#86 add golang sdk GRPC

  • support webhook subscription and stream subscription
  • support async and RR message
  • only support eventmeshmessage now
  • add multiple loadbalancer strategy, support multiple connection later
  • add logger with zap.Logger
  • support uuid and sonyflake to generate unique ID
  • suport atomic.Seqence ID

TODO

  • support cloudevent message
  • support multiple eventmesh server connection

qqeasonchen
qqeasonchen previously approved these changes Jun 6, 2022
Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen
Copy link
Contributor

@walleliu1016 please take a look about license check fail

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #911 (bd77cc6) into master (755df48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #911   +/-   ##
========================================
  Coverage      8.91%   8.91%           
  Complexity      529     529           
========================================
  Files           347     347           
  Lines         21773   21773           
  Branches       2426    2426           
========================================
  Hits           1941    1941           
  Misses        19682   19682           
  Partials        150     150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755df48...bd77cc6. Read the comment docs.

@qqeasonchen
Copy link
Contributor

WARNING Failed to determine the comment style of file: eventmesh-sdk-go/go.sum
WARNING Failed to create review comment, fallback to a plain comment: POST https://api.github.com/repos/apache/incubator-eventmesh/pulls/911/reviews: 403 Resource not accessible by integration []
WARNING Failed to create review comments POST https://api.github.com/repos/apache/incubator-eventmesh/pulls/911/reviews: 403 Resource not accessible by integration []
ERROR the following files don't have a valid license header:
eventmesh-sdk-go/common/protocol/http/body/client/heartbeat_request_body.go
eventmesh-sdk-go/common/protocol/http/body/client/subscribe_request_body.go
eventmesh-sdk-go/common/seq/num.go
eventmesh-sdk-go/go.mod
eventmesh-sdk-go/go.sum
eventmesh-sdk-go/grpc/client_test.go
eventmesh-sdk-go/grpc/conf/config_test.go
eventmesh-sdk-go/grpc/heartbeat_test.go
eventmesh-sdk-go/grpc/loadbalancer/loadbalancer_test.go
eventmesh-sdk-go/grpc/loadbalancer/rule_iphash_test.go
eventmesh-sdk-go/grpc/loadbalancer/rule_random_test.go
eventmesh-sdk-go/grpc/loadbalancer/rule_roundrobin_test.go
eventmesh-sdk-go/grpc/loadbalancer/status_server_test.go
eventmesh-sdk-go/grpc/proto/eventmesh-client_grpc.pb.go

Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit 71f3b9c into apache:master Jun 7, 2022
@qqeasonchen qqeasonchen mentioned this pull request Jun 7, 2022
2 tasks
@ruanwenjun ruanwenjun added this to the 1.5.0 milestone Jun 25, 2022
xwm1992 pushed a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants