-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #417] gRPC design doc and protobuf models #594
Conversation
merged from upstream
…ice, CountDownLatch and PreDestroy hook
# Conflicts: # eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java
…ice, CountDownLatch and PreDestroy hook
You could refer here to exclude the grpc auto-created files from ck. https://docs.gradle.org/current/userguide/checkstyle_plugin.html#sec:checkstyle_tasks |
What went wrong: @qqeasonchen I think we have some improvement when resorting to GitHub's building checks. |
@jinrongluo if grpc implementation is a plugin, there may need a api for grpc/http/tcp etc. |
@keranbingaa can you help to fix it? |
|
@vongosling @qqeasonchen ok,I will try to fix it |
@jinrongluo We could move code to grpc branch temporarily, review after merge @qqeasonchen But first now, we should resolve 2 failure checks. |
@jinrongluo maybe you need do this to solve the failed check |
Thanks @keranbingaa I adding the allowed licenses for grpc and protobuf. the commit is here - 0ef7783 |
@jinrongluo we may discuss this first before merge. |
Glad to see the sdk-gprc implementation, runtime implementation will commit later, right? |
Yes, @qqeasonchen this PR is about protobuff message design. the actual implementation will be coming in next PR. Thanks. |
I agree. in the actual grpc implementation, I will use plugins. This PR is only about design. |
ok, then it can be merged first. |
It's important to note that this is quite a difficult refactoring. you could refer quarkus codes. https://quarkus.io/guides/grpc-getting-started. I'd like to help to opt code for this feature, looking forwards to your code :-) |
* [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * adding license headers * adding grpc build file * [Issue#417] update settings.gradle * [Issue#417] fix grpc generated code styles * [Issue#417] fix grpc generated code styles * [Issue#417] fix grpc generated code styles * [Issue#417] fix grpc generated code styles and license issue * [Issue#417] fix license issue * [Issue apache#417] ignore checkstyle for generated files * [Issue apache#417] adding allow licensed for grpc protobuf Co-authored-by: j00441484 <[email protected]>
Fixes ISSUE #417.
Motivation
Modifications
Documentation