[Issue #417] gRPC design doc and protobuf models #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged from upstream
…ice, CountDownLatch and PreDestroy hook
# Conflicts: # eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java
…ice, CountDownLatch and PreDestroy hook
ruanwenjun
reviewed
Nov 16, 2021
|
Very excited to see this initial shape, keep going... |
vongosling
reviewed
Nov 16, 2021
| message RequestHeader { | ||
| string env = 1; | ||
| string region = 2; | ||
| string idc = 3; |
There was a problem hiding this comment.
region, namespace, idc, rack and so on. these tenant or geographic info should be carefully designed in our v2 version.
There was a problem hiding this comment.
BTW, any guys want to add comment for every field in protocol?
There was a problem hiding this comment.
This is V1 version of protobuf and we are experimenting this grpc transport feature.
Please review and comment on this set of header attributes and improve it in V2. @qqeasonchen @ruanwenjun
Thanks.
eventmesh-connector-plugin/eventmesh-protocol-grpc/src/main/proto/addressbook.proto
Show resolved
Hide resolved
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE #417.
Motivation
Modifications
Documentation