Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4796] Use ThreadPoolFactory to create single thread executor for SourceWorker #4798

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jevinjiang
Copy link
Contributor

Fixes #4796

Motivation

Use ThreadPoolFactory to create thread pool in eventmesh-common model, and Set thread names to facilitate troubleshooting.
Modifications

Documentation

-Does this pull request introduce a new feature? no

…entmesh-common model, and Set thread names to facilitate troubleshooting.
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 16.34%. Comparing base (0250a89) to head (fde8830).
Report is 1 commits behind head on master.

Files Patch % Lines
...org/apache/eventmesh/common/ThreadPoolFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4798       +/-   ##
=============================================
+ Coverage          0   16.34%   +16.34%     
- Complexity        0     1734     +1734     
=============================================
  Files             0      856      +856     
  Lines             0    31245    +31245     
  Branches          0     2698     +2698     
=============================================
+ Hits              0     5106     +5106     
- Misses            0    25660    +25660     
- Partials          0      479      +479     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia changed the title [ISSUE #4796] Use ThreadPoolFactory to create thread pool in eventmes… [ISSUE #4796] Use ThreadPoolFactory to create single thread executor for SourceWorker Mar 20, 2024
@Pil0tXia Pil0tXia merged commit 87172a9 into apache:master Mar 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Create thread pool using custom ThreadPoolFactory
3 participants