-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #1013] Java sdk split multiple sdk by communication protocol #4759
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4759 +/- ##
============================================
+ Coverage 17.62% 17.67% +0.05%
- Complexity 1784 1785 +1
============================================
Files 805 798 -7
Lines 29924 29838 -86
Branches 2580 2577 -3
============================================
+ Hits 5273 5275 +2
+ Misses 24169 24082 -87
+ Partials 482 481 -1 ☔ View full report in Codecov by Sentry. |
I think the naming of |
ye,I think your naming method looks better. |
too much sdks for users, doesn't it? |
makes sense. cc @xwm1992 |
Is it necessary to split java-sdk into so many modules? |
The minimum granularity of the original Java-SDK was 'client':http-client、grpc-client、tcp-client、workflow-client、catalog-client,so I split it according to this dimension to let each SDK have a single responsibility as much as possible. But it seems bring some inconvenience,such as users should dependent on multiple SDKs if users want to use the feature, bring more sdks, etc. The issue originally aims to split java sdk to multiple sdk by communication protocol, implement the slimming of the java sdk.. Maybe another method to reduce SDKs' number and meet issue's requirement is: put http, tcp, grpc individually(split by protocol), put other clients in one SDK. cn: 但是这种分法带来了一些问题,比如用户如果想使用多个协议,需要依赖多个SDK 以及带来了很多SDK 等等。 这个Issue原来的目的是按照协议分割Java SDK使得Java SDK更加精简。也许另外一种减少SDK数量并且满足issue要求的方法是:将grpc、http、tcp独立开(按照协议),将其他的客户端放在一个SDK下。 |
Please provide some suggestions for splitting |
My personal opinion is to divide them according to different languages, such as Rust, Java, and Go. Instead of dividing them for each protocol, dividing them too finely will lead to a very bloated project. At the same time, whether other language SDKs should also be divided in this way. |
What is the original intention of issue #1013? |
@scwlkq thank you for your contribution, but we think it is not the best time to do this refacoring now. |
Fixes #1013
Motivation
Java sdk split multiple sdk by communication protocol
Modifications
However, the Catalog requires the use of the selector and GRPC modules, so they are placed together. The same applies to the WorkFlow module and selector module.
I am not sure if this segmentation method is correct. If there are any shortcomings, please let me kown, and i will correct it.
Documentation