Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4705] Remove redundant Gradle build task 'jar' #4706

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jan 1, 2024

Fixes #4705.

Motivation

When writing this PR apache/eventmesh-site#170, I noticed this build task.

Gradle build task jar is already depended by dist and included in build, so there is no need to excute it.

image

Modifications

Remove task jar from compilation commands.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd2aeb9) 17.39% compared to head (794b8b1) 17.37%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4706      +/-   ##
============================================
- Coverage     17.39%   17.37%   -0.03%     
- Complexity     1759     1760       +1     
============================================
  Files           797      797              
  Lines         29850    29891      +41     
  Branches       2579     2574       -5     
============================================
+ Hits           5192     5193       +1     
- Misses        24177    24219      +42     
+ Partials        481      479       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@harshithasudhakar harshithasudhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia closed this Jan 4, 2024
@Pil0tXia Pil0tXia deleted the pil0txia_enhance_4705 branch January 4, 2024 05:06
@Pil0tXia Pil0tXia restored the pil0txia_enhance_4705 branch January 4, 2024 06:14
@Pil0tXia Pil0tXia reopened this Jan 4, 2024
@mxsm mxsm merged commit 8eb3d45 into apache:master Jan 6, 2024
18 of 23 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia_enhance_4705 branch January 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove redundant Gradle build task 'jar'
5 participants