[MINOR] Fix ci check error #4543

xwm1992 · 2023-11-06T09:38:23Z

Fixes #.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

codecov · 2023-11-06T10:11:17Z

Codecov Report

Merging #4543 (5557311) into master (c350528) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5557311 differs from pull request most recent head 53715a6. Consider uploading reports for the commit 53715a6 to get more accurate results

@@             Coverage Diff              @@
##             master    #4543      +/-   ##
============================================
+ Coverage     16.28%   16.30%   +0.02%     
- Complexity     1591     1592       +1     
============================================
  Files           747      747              
  Lines         28954    28965      +11     
  Branches       2525     2541      +16     
============================================
+ Hits           4715     4723       +8     
- Misses        23790    23793       +3     
  Partials        449      449

see 13 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

pandaapo · 2023-11-06T10:53:02Z

.github/workflows/ci.yml

+      - if: matrix.language == 'cpp' || matrix.language == 'csharp'
+        name: Build C
+        run: |
+          make   


The error 'CodeQL detected code written in Java/Kotlin, Go and c, but not any written in C/C++' is still reported in CI. I saw that the CI result shows that this step has been skipped. Is it because this judgment condition requires the addition of matrix. language=='c'?

CI仍然报这个错"CodeQL detected code written in Java/Kotlin, Go and c, but not any written in C/C++"。我看CI结果显示这一步跳过了，是不是因为这个判断条件需要加上matrix.language =='c'？

The error 'CodeQL detected code written in Java/Kotlin, Go and c, but not any written in C/C++' is still reported in CI. I saw that the CI result shows that this step has been skipped. Is it because this judgment condition requires the addition of matrix. language=='c'?

CI仍然报这个错"CodeQL detected code written in Java/Kotlin, Go and c, but not any written in C/C++"。我看CI结果显示这一步跳过了，是不是因为这个判断条件需要加上matrix.language =='c'？

cpp is c/c++, and there are language settings to display it in CodeQL

cpp就是c/c++，CodeQL里面有显示它的语言设置

xwm1992#11

This is the pr modification of my own repository. It shows that the ci check passed, but the submission to the apache repository failed.

这是我自己仓库的pr修改，显示ci check是通过了的，但是提交到主仓库就失败了

but the submission to the apache repository failed.

It should be a side effect of these unsynchronized commits: xwm1992/EventMesh@master...apache:eventmesh:master

应该是这些没同步的commit带来的副作用：xwm1992/EventMesh@master...apache:eventmesh:master

xwm1992#11
This is the pr modification of my own repository. It shows that the ci check passed, but the submission to the apache repository failed.

After comparing the CI information of the two repositories, there are still differences. The former's CodeQL seems to only analyze Java, while the latter is not. But I am not sure about the specific reason.

对比了一下两个仓库的CI信息，还是有差别的。前者的CodeQL好像只分析java的，后者则不是。但具体原因我也不清楚。

xwm1992#11
This is the pr modification of my own repository. It shows that the ci check passed, but the submission to the apache repository failed.

会不会跟make的路径有关，在根目录下面不能进行make 编译处理C而需要到sdk Makefile文件目录才能

Could it be related to the path of make? Compilation processing of C cannot be performed under the root directory by make, but requires access to the directory of the sdk Makefile file.

In #4323, c sdk adds some third-party libraries using submodules. git doesn't clone or use submodules by default. Needs to make or scan them after adding them.

在 #4323 中，c sdk使用了submodule的方式添加了一些第三方库。git默认是不clone或使用submodule的，需要添加它们之后再make或扫描。

github/codeql#14703
I raised this issue to the codeql community. We can follow it and reply under this issue.

我向codeql 社区提了这个问题的issue，大家可以关注并在这个issue下面回复一下

The matrix does not define a language property, so matrix.language evaluates to null.

pandaapo · 2023-11-07T10:11:51Z

.github/workflows/ci.yml

@@ -33,6 +33,7 @@ jobs:
      matrix:
        os: [ ubuntu-latest, macOS-latest ]
        java: [ 8, 11 ]
+        language: ['java', 'go', 'c']


Does the C/C++ language name here need to be consistent with the cpp in the following if: matrix. language=='cpp' || matrix.language == 'csharp'?

pandaapo · 2023-11-07T11:59:11Z

Now Build C can be executed. And the error is reported: make: * * * No targets specified and no makefile found. Stop. Error: Process completed with exit code 2. As stated in this comment.

To solve this error, I tried the command make -C ./eventmesh-sdks/eventmesh-sdk-c before, and the following error will be reported:

make: Entering directory '/home/runner/work/eventmesh/eventmesh/eventmesh-sdks/eventmesh-sdk-c'

Building  ==> third_party/libcurl.a...
/bin/sh: 1: ./configure: not found
make: *** [makefile:56: third_party/libcurl.a] Error 127
make: Leaving directory '/home/runner/work/eventmesh/eventmesh/eventmesh-sdks/eventmesh-sdk-c'
Error: Process completed with exit code 2.

Based on this comment, I am not sure if adding some commands will work, such as changing the script to the following:

git submodule init
git submodule update 
make -C ./eventmesh-sdks/eventmesh-sdk-c

xwm1992 · 2023-11-07T12:29:42Z

Now Build C can be executed. And the error is reported: make: * * * No targets specified and no makefile found. Stop. Error: Process completed with exit code 2. As stated in this comment.

To solve this error, I tried the command make -C ./eventmesh-sdks/eventmesh-sdk-c before, and the following error will be reported:
make: Entering directory '/home/runner/work/eventmesh/eventmesh/eventmesh-sdks/eventmesh-sdk-c'

Building  ==> third_party/libcurl.a...
/bin/sh: 1: ./configure: not found
make: *** [makefile:56: third_party/libcurl.a] Error 127
make: Leaving directory '/home/runner/work/eventmesh/eventmesh/eventmesh-sdks/eventmesh-sdk-c'
Error: Process completed with exit code 2.
Based on this comment, I am not sure if adding some commands will work, such as changing the script to the following:
git submodule init
git submodule update 
make -C ./eventmesh-sdks/eventmesh-sdk-c

#4542
as you mentioned the error, maybe merge this pull request can fix this error.

…t-ci

pandaapo · 2023-11-08T02:53:27Z

From the error information reported, it seems that the third-party libraries as git submodules have not been introduced yet, as I found the file 'configure.ac' in one of the third-party libraries 'curl'.

Building  ==> third_party/libcurl.a...
autoreconf: error: 'configure.ac' is required
make: *** [third_party/libcurl.a] Error 1

xwm1992 · 2023-11-08T03:32:12Z

企业微信截图_2838c2da-7988-444c-aa6b-4d7bcb1432ba

Since compile c code face the git permission error, I'll jump the c code compile and codeql check for now.

aibaars · 2023-11-09T08:40:55Z

Since compile c code face the git permission error, I'll jump the c code compile and codeql check for now.

Have you tried submodules: true on the actions/checkout step? It converts SSH URLs to HTTPS ones, which should avoid the public key permission errors.

# Whether to checkout submodules: true to checkout submodules or recursive to
# recursively checkout submodules.
#
# When the ssh-key input is not provided, SSH URLs beginning with
# [email protected]: are converted to HTTPS.
#
# Default: false
submodules: ''

pandaapo · 2023-11-11T04:18:32Z

tried submodules: true on the actions/checkout step

It's helpful.

fix ci check error

0e1601c

pandaapo reviewed Nov 6, 2023

View reviewed changes

xwm1992 mentioned this pull request Nov 7, 2023

codeql fails with exit code 32 for c language analysis under the macOS environment github/codeql#14703

Open

Update ci.yml

d0582a2

pandaapo reviewed Nov 7, 2023

View reviewed changes

Update ci.yml

374ee13

xwm1992 added 2 commits November 7, 2023 20:30

Update ci.yml

021aaed

Merge branch 'master' of https://github.com/apache/eventmesh into tes…

7baf1c6

…t-ci

xwm1992 added 2 commits November 8, 2023 10:53

Update ci.yml

a613bca

Update ci.yml

53715a6

pandaapo approved these changes Nov 8, 2023

View reviewed changes

lrhkobe approved these changes Nov 9, 2023

View reviewed changes

xwm1992 merged commit 3a580dc into apache:master Nov 9, 2023

This was referenced Jan 12, 2024

[ISSUE #4737] Separate codeql workflow #4740

Merged

[Bug] CI Build C task compile error: [makefile:81: librmb.a] Error 9 #4742

Open

Pil0tXia mentioned this pull request Apr 14, 2024

[Bug] Failed to checkout Git submodules in CI Build C task #4836

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MINOR] Fix ci check error #4543

[MINOR] Fix ci check error #4543

xwm1992 commented Nov 6, 2023

codecov bot commented Nov 6, 2023 •

edited

Loading

pandaapo Nov 6, 2023

xwm1992 Nov 6, 2023 •

edited

Loading

xwm1992 Nov 6, 2023 •

edited

Loading

Pil0tXia Nov 6, 2023 •

edited by pandaapo

Loading

pandaapo Nov 6, 2023 •

edited

Loading

mxsm Nov 7, 2023 •

edited by pandaapo

Loading

Pil0tXia Nov 7, 2023

xwm1992 Nov 7, 2023

aibaars Nov 7, 2023

pandaapo Nov 7, 2023 •

edited

Loading

aibaars Nov 7, 2023

pandaapo commented Nov 7, 2023

xwm1992 commented Nov 7, 2023

pandaapo commented Nov 8, 2023

xwm1992 commented Nov 8, 2023

aibaars commented Nov 9, 2023 •

edited

Loading

pandaapo commented Nov 11, 2023

[MINOR] Fix ci check error #4543

[MINOR] Fix ci check error #4543

Conversation

xwm1992 commented Nov 6, 2023

Motivation

Modifications

Documentation

codecov bot commented Nov 6, 2023 • edited Loading

Codecov Report

pandaapo Nov 6, 2023

Choose a reason for hiding this comment

xwm1992 Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

xwm1992 Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Pil0tXia Nov 6, 2023 • edited by pandaapo Loading

Choose a reason for hiding this comment

pandaapo Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

mxsm Nov 7, 2023 • edited by pandaapo Loading

Choose a reason for hiding this comment

Pil0tXia Nov 7, 2023

Choose a reason for hiding this comment

xwm1992 Nov 7, 2023

Choose a reason for hiding this comment

aibaars Nov 7, 2023

Choose a reason for hiding this comment

pandaapo Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

aibaars Nov 7, 2023

Choose a reason for hiding this comment

pandaapo commented Nov 7, 2023

xwm1992 commented Nov 7, 2023

pandaapo commented Nov 8, 2023

xwm1992 commented Nov 8, 2023

aibaars commented Nov 9, 2023 • edited Loading

pandaapo commented Nov 11, 2023

codecov bot commented Nov 6, 2023 •

edited

Loading

xwm1992 Nov 6, 2023 •

edited

Loading

xwm1992 Nov 6, 2023 •

edited

Loading

Pil0tXia Nov 6, 2023 •

edited by pandaapo

Loading

pandaapo Nov 6, 2023 •

edited

Loading

mxsm Nov 7, 2023 •

edited by pandaapo

Loading

pandaapo Nov 7, 2023 •

edited

Loading

aibaars commented Nov 9, 2023 •

edited

Loading