Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3906] Do some code optimization.[EventMeshUtil] #4527

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

tooo-bad
Copy link
Contributor

@tooo-bad tooo-bad commented Nov 1, 2023

Fixes #3906

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4527 (5120ff5) into master (2bfc1ae) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5120ff5 differs from pull request most recent head 4530502. Consider uploading reports for the commit 4530502 to get more accurate results

@@            Coverage Diff            @@
##             master    #4527   +/-   ##
=========================================
  Coverage     16.09%   16.09%           
  Complexity     1550     1550           
=========================================
  Files           730      730           
  Lines         28640    28640           
  Branches       2523     2523           
=========================================
  Hits           4611     4611           
  Misses        23581    23581           
  Partials        448      448           
Files Coverage Δ
...g/apache/eventmesh/runtime/util/EventMeshUtil.java 76.86% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm merged commit bdacd23 into apache:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Method needlessly defines parameter with concrete classes[EventMeshUtil]
4 participants