-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4521] Enhance clarity and avoid concept conflict in exception enum #4524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
============================================
+ Coverage 15.47% 16.09% +0.62%
- Complexity 1452 1550 +98
============================================
Files 691 730 +39
Lines 28106 28640 +534
Branches 2626 2523 -103
============================================
+ Hits 4349 4611 +262
- Misses 23312 23581 +269
- Partials 445 448 +3
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #4521.
Motivation
The
Message
subclass represents the string message for exceptions; however, its concept may potentially conflict with MQ messages. To address this concern, the class name has been changed while retaining the field name.Type
refers to a kind or category, where its constituents share similar characteristics. It can pertain to a single exception or multiple exceptions of the same type, which might lead to potential ambiguity. Therefore, its class name has been exacted to the primary classification levelCategory
.The
Errors
enum has been renamed toStatus
to accommodate additional situations, such as the status of a K8s pod beingDeploying
.Modifications
The names of exception enum members have been optimized to better align with their usage in the code, adhere more closely to English grammar, and avoid potential conflicts with future-introduced concepts.
Documentation