Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4321] Add Examples And Configs For C SDK #4326

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

zhurq
Copy link
Contributor

@zhurq zhurq commented Aug 4, 2023

Fixes #4321.

Motivation

Add Examples And Configs.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4326 (10bfcc4) into master (fef56a5) will decrease coverage by 0.26%.
Report is 137 commits behind head on master.
The diff coverage is 13.38%.

❗ Current head 10bfcc4 differs from pull request most recent head 7dfbbdd. Consider uploading reports for the commit 7dfbbdd to get more accurate results

@@             Coverage Diff              @@
##             master    #4326      +/-   ##
============================================
- Coverage     16.35%   16.09%   -0.26%     
- Complexity     1362     1550     +188     
============================================
  Files           594      730     +136     
  Lines         25393    28640    +3247     
  Branches       2393     2523     +130     
============================================
+ Hits           4152     4611     +459     
- Misses        20818    23581    +2763     
- Partials        423      448      +25     
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...org/apache/eventmesh/common/ThreadPoolFactory.java 16.66% <ø> (ø)
.../eventmesh/common/config/convert/ConverterMap.java 71.73% <ø> (ø)
...common/config/convert/converter/ListConverter.java 54.16% <ø> (ø)
...mmon/config/convert/converter/ObjectConverter.java 59.77% <ø> (ø)
...entmesh/common/enums/EventMeshDataContentType.java 0.00% <ø> (ø)
...eventmesh/common/exception/EventMeshException.java 0.00% <ø> (ø)
...apache/eventmesh/common/file/WatchFileManager.java 67.64% <100.00%> (+9.31%) ⬆️
.../eventmesh/common/loadbalance/LoadBalanceType.java 80.00% <ø> (ø)
.../common/loadbalance/RandomLoadBalanceSelector.java 66.66% <ø> (ø)
... and 149 more

... and 400 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alonexc
Copy link
Contributor

Alonexc commented Aug 11, 2023

need add license.
image

Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrhkobe lrhkobe merged commit e13ac79 into apache:master Nov 1, 2023
@zhurq zhurq deleted the feature/c-sdk-example branch November 6, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Examples And Configs For C SDK
4 participants