-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement #3495] Add redis admin #4302
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4302 +/- ##
============================================
- Coverage 16.87% 16.85% -0.03%
Complexity 1428 1428
============================================
Files 593 596 +3
Lines 26035 26087 +52
Branches 2366 2380 +14
============================================
+ Hits 4394 4397 +3
- Misses 21215 21263 +48
- Partials 426 427 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Some of your classes have almost the same content with classes in Additionally, |
I thought about it first. considering there is a task related #4040, I just simply added the redis-admin and submit the pr waiting for further disscusion. I am still confused about the admin part in |
Contributing code in this way is not good, both for you and for EventMesh. You should program only after fully understanding the relevant code you are dealing with, and verify the functionality of your code. |
I'm sorry for my thoughtless behavior in this pr and I will make a plan about it first the next time. |
Fixes #3495.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Documentation