[ISSUE #3515] Do some code optimization[AuthTokenUtils] #3644

kyooosukedn · 2023-04-06T22:13:08Z

Fixes #3515 .

Motivation

Code Optimization on AuthTokenUtils.java
Remove redundancy

Modifications

Remove duplicate code and redundancies

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Alonexc

LGTM

Alonexc · 2023-04-07T02:25:54Z

Please check the checkstyle.

kyooosukedn · 2023-04-07T13:55:47Z

Please check the checkstyle.

Hi, how do I get those warnings? I ran ./gradlew check and did code inspection on file AuthTokenUtils.java and found nothing, I have imported checkstyle.xml though

Alonexc · 2023-04-12T08:10:23Z

@kyooosukedn
Download this plugin：

Import the checkstyle of the local project and check the box.

Alonexc · 2023-04-12T08:15:11Z

...mesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/HTTPClientHandler.java

@@ -139,7 +139,7 @@ void list(HttpExchange httpExchange) throws IOException {
            });

            String result = JsonUtils.toJSONString(getClientResponseList);
-            httpExchange.sendResponseHeaders(200, result.getBytes().length);
+            httpExchange.sendResponseHeaders(200, result.getBytes(Constants.DEFAULT_CHARSET).length);


Here Constants.DEFAULT_CHARSET needs to be imported:
org.apache.eventmesh.common.Constants;

kyooosukedn · 2023-04-25T21:11:14Z

Hi @Alonexc Is there something else that needs to be done?

Pil0tXia · 2024-01-09T14:10:02Z

Please resolve conflicts.

Pil0tXia

I didn't see these changes required in #3515:

b. Remove redundant initializers.
c. Use 'Objects.requireNonNull()' to avoid an NPE.
d. Replace this if-then-else statement by a single return statement
e. Remove the extra "{}".

Please supplement.😊

Besides, please fix checkstyle warnings: https://github.com/apache/eventmesh/actions/runs/7481706701/job/20372145878

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java

codecov · 2024-01-14T18:52:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5850d54) 17.55% compared to head (12b521c) 17.59%.
Report is 6 commits behind head on master.

❗ Current head 12b521c differs from pull request most recent head 13b2bee. Consider uploading reports for the commit 13b2bee to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3644      +/-   ##
============================================
+ Coverage     17.55%   17.59%   +0.04%     
+ Complexity     1778     1774       -4     
============================================
  Files           797      797              
  Lines         29871    29786      -85     
  Branches       2581     2573       -8     
============================================
- Hits           5243     5242       -1     
+ Misses        24145    24063      -82     
+ Partials        483      481       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java

kyooosukedn · 2024-01-16T22:18:51Z

Hi @Pil0tXia, I have corrected as you suggested. Thank u for the review :)

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java

Pil0tXia

LGTM

Pil0tXia · 2024-01-19T08:08:38Z

cc @Alonexc

github-actions · 2024-04-22T18:32:09Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

codecov-commenter · 2024-04-22T18:32:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e04156b) to head (d48a930).
Report is 69 commits behind head on master.

❗ Current head d48a930 differs from pull request most recent head c1d287c

Please upload reports for the commit c1d287c to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #3644       +/-   ##
============================================
- Coverage     16.20%       0   -16.21%     
============================================
  Files           857       0      -857     
  Lines         30883       0    -30883     
  Branches       2685       0     -2685     
============================================
- Hits           5005       0     -5005     
+ Misses        25410       0    -25410     
+ Partials        468       0      -468

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pil0tXia · 2024-04-23T03:43:42Z

@kyooosukedn Sorry for the delay. May you please resolve conflicts? 😊

@Alonexc May you please help merge this PR?

kyooosukedn · 2024-04-28T11:57:41Z

@Alonexc @Pil0tXia kindly review this, thanks :)

Pil0tXia

Re-approval. cc @Alonexc

Pil0tXia · 2024-06-01T16:52:24Z

Closing to re-trigger CI.

Code optimization

d7744ce

Alonexc reviewed Apr 7, 2023

View reviewed changes

xwm1992 changed the title ~~Code optimization~~ [ISSUE #3515] Do some code optimization[AuthTokenUtils] Apr 7, 2023

kyooosukedn added 2 commits April 7, 2023 16:02

Remove unused imports

8f72bdd

Added one forgotten import 'Objects'

e840793

Alonexc reviewed Apr 12, 2023

View reviewed changes

Added Constants import

3709e3d

Merge branch 'master' into 3515

bc88f6e

Pil0tXia reviewed Jan 11, 2024

View reviewed changes

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java Outdated Show resolved Hide resolved

kyooosukedn added 2 commits January 14, 2024 15:52

removed unnecessary space

fd6518a

fixed code optimization

12b521c

Pil0tXia requested changes Jan 16, 2024

View reviewed changes

corrected some small changes

7c082fe

Pil0tXia requested changes Jan 17, 2024

View reviewed changes

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java Outdated Show resolved Hide resolved

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java Outdated Show resolved Hide resolved

redundant lines

a49336e

Pil0tXia requested changes Jan 18, 2024

View reviewed changes

...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java Outdated Show resolved Hide resolved

redundant lines

42c0d06

Pil0tXia previously approved these changes Jan 18, 2024

View reviewed changes

optimized returned reply in subscribe method

98bf805

kyooosukedn dismissed Pil0tXia’s stale review via 98bf805 January 19, 2024 22:55

kyooosukedn added 2 commits January 19, 2024 23:58

reverted correct change

29ccb37

reverted back

13b2bee

Pil0tXia previously approved these changes Jan 20, 2024

View reviewed changes

Pil0tXia requested a review from Alonexc January 20, 2024 14:37

github-actions bot added the Stale label Apr 22, 2024

github-actions bot removed the Stale label Apr 23, 2024

merge master

c1d287c

kyooosukedn dismissed Pil0tXia’s stale review via c1d287c April 23, 2024 21:46

Pil0tXia approved these changes Apr 28, 2024

View reviewed changes

pchengma approved these changes May 30, 2024

View reviewed changes

Pil0tXia closed this Jun 1, 2024

Pil0tXia reopened this Jun 1, 2024

Pil0tXia merged commit 498c350 into apache:master Jun 1, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #3515] Do some code optimization[AuthTokenUtils] #3644

[ISSUE #3515] Do some code optimization[AuthTokenUtils] #3644

kyooosukedn commented Apr 6, 2023

Alonexc left a comment

Alonexc commented Apr 7, 2023

kyooosukedn commented Apr 7, 2023

Alonexc commented Apr 12, 2023

Alonexc Apr 12, 2023

kyooosukedn Apr 12, 2023

kyooosukedn commented Apr 25, 2023

Pil0tXia commented Jan 9, 2024

Pil0tXia left a comment •

edited

Loading

codecov bot commented Jan 14, 2024 •

edited

Loading

kyooosukedn commented Jan 16, 2024

Pil0tXia left a comment

Pil0tXia commented Jan 19, 2024

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024 •

edited by codecov bot

Loading

Pil0tXia commented Apr 23, 2024

kyooosukedn commented Apr 28, 2024

Pil0tXia left a comment •

edited

Loading

Pil0tXia commented Jun 1, 2024

[ISSUE #3515] Do some code optimization[AuthTokenUtils] #3644

[ISSUE #3515] Do some code optimization[AuthTokenUtils] #3644

Conversation

kyooosukedn commented Apr 6, 2023

Motivation

Modifications

Documentation

Alonexc left a comment

Choose a reason for hiding this comment

Alonexc commented Apr 7, 2023

kyooosukedn commented Apr 7, 2023

Alonexc commented Apr 12, 2023

Alonexc Apr 12, 2023

Choose a reason for hiding this comment

kyooosukedn Apr 12, 2023

Choose a reason for hiding this comment

kyooosukedn commented Apr 25, 2023

Pil0tXia commented Jan 9, 2024

Pil0tXia left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 14, 2024 • edited Loading

Codecov Report

kyooosukedn commented Jan 16, 2024

Pil0tXia left a comment

Choose a reason for hiding this comment

Pil0tXia commented Jan 19, 2024

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024 • edited by codecov bot Loading

Codecov Report

Pil0tXia commented Apr 23, 2024

kyooosukedn commented Apr 28, 2024

Pil0tXia left a comment • edited Loading

Choose a reason for hiding this comment

Pil0tXia commented Jun 1, 2024

Pil0tXia left a comment •

edited

Loading

codecov bot commented Jan 14, 2024 •

edited

Loading

codecov-commenter commented Apr 22, 2024 •

edited by codecov bot

Loading

Pil0tXia left a comment •

edited

Loading