Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2803] Fix SpringBootDemoApplication crash #2834

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

seriouszyx
Copy link
Member

Signed-off-by: Yixiang Zhao [email protected]

Fixes #2803.

Motivation

When an exception occurs in a statement inside try, the program will simply crash. Catching exceptions in time helps to reduce the impact of exceptions.

Modifications

Catch the IOException directly.

Documentation

  • Does this pull request introduce a new feature? (no)

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2834 (fe86ae4) into master (1dda857) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head fe86ae4 differs from pull request most recent head fbe29cc. Consider uploading reports for the commit fbe29cc to get more accurate results

@@             Coverage Diff              @@
##             master    #2834      +/-   ##
============================================
- Coverage     11.60%   11.59%   -0.01%     
  Complexity      911      911              
============================================
  Files           503      503              
  Lines         28102    28102              
  Branches       2861     2858       -3     
============================================
- Hits           3261     3259       -2     
- Misses        24546    24548       +2     
  Partials        295      295              
Impacted Files Coverage Δ
...org/apache/eventmesh/runtime/util/WebhookUtil.java 58.06% <0.00%> (-6.23%) ⬇️
.../admin/handler/QueryRecommendEventMeshHandler.java 33.33% <0.00%> (-3.71%) ⬇️
.../trace/pinpoint/exporter/PinpointSpanExporter.java 68.24% <0.00%> (-0.68%) ⬇️
...sh/client/http/producer/EventMeshHttpProducer.java 0.00% <0.00%> (ø)
...untime/core/protocol/http/push/HTTPClientPool.java 0.00% <0.00%> (ø)
...otocol/meshmessage/MeshMessageProtocolAdaptor.java 3.84% <0.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992
Copy link
Contributor

xwm1992 commented Jan 6, 2023

I'll merge this pr for now, to reduce the connection refused exception for each subscribtion action in http, but the key problem is the obtainDeliveryAgreement method, we need to find why this httpclient request cause the exception. @seriouszyx @jonyangx

@xwm1992 xwm1992 merged commit ead24b9 into apache:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fail to run the HTTP demos
3 participants