Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2707] Method stores return result in local before immediately returning it [AbstractRemotingServer] #2752

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

jonyangx
Copy link
Contributor

@jonyangx jonyangx commented Dec 31, 2022

Fixes #2707 .

Motivation

Method stores return result in local before immediately returning it [AbstractRemotingServer]

Modifications

refactor
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractRemotingServer.java
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshTCPServer.java

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? ( not documented)

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #2752 (556a566) into master (9e81ef5) will decrease coverage by 0.00%.
The diff coverage is 2.54%.

@@             Coverage Diff              @@
##             master    #2752      +/-   ##
============================================
- Coverage     11.92%   11.91%   -0.01%     
- Complexity      905      906       +1     
============================================
  Files           476      476              
  Lines         27068    27081      +13     
  Branches       2753     2765      +12     
============================================
  Hits           3227     3227              
- Misses        23554    23563       +9     
- Partials        287      291       +4     
Impacted Files Coverage Δ
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 0.00% <0.00%> (ø)
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.56% <1.69%> (-0.02%) ⬇️
...eventmesh/runtime/boot/AbstractRemotingServer.java 4.25% <6.66%> (+1.22%) ⬆️
.../apache/eventmesh/runtime/util/RemotingHelper.java 50.00% <0.00%> (-5.56%) ⬇️
...g/apache/eventmesh/runtime/util/EventMeshUtil.java 73.38% <0.00%> (-0.70%) ⬇️
...untime/core/protocol/http/push/HTTPClientPool.java 0.00% <0.00%> (ø)
...me/core/protocol/grpc/service/ConsumerService.java 0.00% <0.00%> (ø)
...e/core/protocol/tcp/client/task/SubscribeTask.java 0.00% <0.00%> (ø)
...org/apache/eventmesh/runtime/util/WebhookUtil.java 63.88% <0.00%> (+1.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit d4e863e into apache:master Dec 31, 2022
@jonyangx jonyangx deleted the issue2707 branch December 31, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Method stores return result in local before immediately returning it [AbstractRemotingServer]
2 participants