Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #980]Made some fileds are final #1015

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

liuzwei
Copy link
Contributor

@liuzwei liuzwei commented Jul 12, 2022

Fixes ISSUE #980 .

Motivation

Some fileds need to be made final.

Modifications

I have made some fields are final .

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@xwm1992 xwm1992 added this to the 1.6.0 milestone Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1015 (a0ebfa1) into master (42ffaeb) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head a0ebfa1 differs from pull request most recent head ed32988. Consider uploading reports for the commit ed32988 to get more accurate results

@@             Coverage Diff             @@
##             master   #1015      +/-   ##
===========================================
- Coverage      8.39%   8.26%   -0.13%     
+ Complexity      529     526       -3     
===========================================
  Files           362     362              
  Lines         23242   23118     -124     
  Branches       2546    2546              
===========================================
- Hits           1951    1911      -40     
+ Misses        21141   21055      -86     
- Partials        150     152       +2     
Impacted Files Coverage Δ
...e/eventmesh/common/config/CommonConfiguration.java 83.87% <ø> (-3.79%) ⬇️
...che/eventmesh/common/protocol/tcp/codec/Codec.java 62.22% <ø> (-1.22%) ⬇️
...connector/rocketmq/config/ClientConfiguration.java 0.00% <ø> (ø)
...time/configuration/EventMeshGrpcConfiguration.java 0.00% <ø> (ø)
...time/configuration/EventMeshHTTPConfiguration.java 0.00% <ø> (ø)
...ntime/configuration/EventMeshTCPConfiguration.java 0.00% <ø> (ø)
...ventmesh/runtime/constants/EventMeshConstants.java 0.00% <ø> (ø)
...e/eventmesh/client/tcp/common/EventMeshCommon.java 0.00% <ø> (-87.50%) ⬇️
...ava/org/apache/eventmesh/common/utils/IPUtils.java 33.33% <0.00%> (-6.49%) ⬇️
...sh/client/grpc/consumer/EventMeshGrpcConsumer.java 75.80% <0.00%> (-1.62%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ffaeb...ed32988. Read the comment docs.

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 24e5c19 into apache:master Jul 12, 2022
xwm1992 added a commit that referenced this pull request Aug 4, 2022
[ISSUE #980]Made some fileds are final
close #980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants