Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Adding Flow control RateLimiter support in Http Message Send Processor #523

Closed
jinrongluo opened this issue Sep 16, 2021 · 3 comments
Closed

[Enhancement] Adding Flow control RateLimiter support in Http Message Send Processor #523

jinrongluo opened this issue Sep 16, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone
1.3.0

Comments

@jinrongluo
Copy link
Contributor

Enhancement Request

In Eventmesh runtime, there is flow control using RateLimiter in TCP MessageTransfer processor, and HTTP Batch Message send processor. However flow control is missing in Http MessageSend (Sync & Async) procrssors.

I have implemented RateLimiter for Http Message Send processors, and would like to contribute.

I will create a PR later.

Is your enhancement request related to a problem? Please describe

Adding RateLimiter to Http Message Send Processor.

Using property file to set the rate limit

Describe the solution you'd like

Implementation is similar to Ratelimiter for TCP and HTTP Batch Send

Describe alternatives you've considered

Additional context
@jinrongluo jinrongluo added the enhancement New feature or request label Sep 16, 2021
@qqeasonchen
Copy link
Contributor

good question, you can refer to tcp ratelimiter implementation.

@apache apache deleted a comment from jinrongluo Sep 17, 2021
jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Sep 17, 2021
@jinrongluo
Issue apache#523 adding FlowControl Ratelimiter support for Http mess…
498327d 
…age send processors
@jinrongluo jinrongluo mentioned this issue Sep 17, 2021
Merged
@jinrongluo
Copy link
Contributor Author

thanks @qqeasonchen I created PR - #524

Please review. thanks.

jinrongluo added a commit to jinrongluo/incubator-eventmesh that referenced this issue Sep 24, 2021
@jinrongluo
[Issue apache#523] Fixing the Eventmesh ratelimit error return code.
14459b0
xwm1992 pushed a commit that referenced this issue Sep 27, 2021
@jinrongluo
[Issue #523] Adding Flow control RateLimiter support in Http Message …
546765e 
…Send Processor (#524)

* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* Issue #523 adding FlowControl Ratelimiter support for Http message send processors

* [Issue #523] Fixing the Eventmesh ratelimit error return code.

Co-authored-by: j00441484 <[email protected]>
@jinrongluo
Copy link
Contributor Author

PR merged, close issue.

@xwm1992 xwm1992 added this to the 1.3.0 milestone Dec 16, 2021
@xwm1992 xwm1992 changed the title Adding Flow control RateLimiter support in Http Message Send Processor [Enhancement] Adding Flow control RateLimiter support in Http Message Send Processor Dec 16, 2021
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
@jinrongluo @xwm1992
[Issue apache#523] Adding Flow control RateLimiter support in Http Me…
492ae1a 
…ssage Send Processor (apache#524)

* [Issue apache#337] Fix HttpSubscriber startup issue

* [Issue apache#337] test commit

* [Issue apache#337] revert test commit

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue apache#337] Address code review comment for Subscriber Demo App

* Issue apache#523 adding FlowControl Ratelimiter support for Http message send processors

* [Issue apache#523] Fixing the Eventmesh ratelimit error return code.

Co-authored-by: j00441484 <[email protected]>
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@jinrongluo
[Issue #523] Adding Flow control RateLimiter support in Http Message …
dcd409d 
…Send Processor (#524)

* [Issue #337] Fix HttpSubscriber startup issue

* [Issue #337] test commit

* [Issue #337] revert test commit

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook

* [Issue #337] Address code review comment for Subscriber Demo App

* Issue #523 adding FlowControl Ratelimiter support for Http message send processors

* [Issue #523] Fixing the Eventmesh ratelimit error return code.

Co-authored-by: j00441484 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@xwm1992 @qqeasonchen @jinrongluo