Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Webhook support for HTTP Source Connector #4869

Closed
2 of 3 tasks
Pil0tXia opened this issue Apr 30, 2024 · 1 comment · Fixed by #4913
Closed
2 of 3 tasks

[Feature] Add Webhook support for HTTP Source Connector #4869

Pil0tXia opened this issue Apr 30, 2024 · 1 comment · Fixed by #4913
Assignees
@cnzakii
Labels
feature help wanted Extra attention is needed

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 30, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

This issue is a subtask of #4825.

Referencing the existing eventmesh-webhook module and its documentation, support the following functionalities:

  • Utilize the HTTP Source Connector as a Webhook server, capable of receiving event deliveries from most third-party platforms using a common Webhook protocol, such as UptimeRobot/Better Stack Uptime, Discord, and more.
  • Support the GitHub Webhook protocol, allowing users to implement non-standard Webhook protocols for specific third-party platforms on their own (for example, refer to org.apache.eventmesh.webhook.receive.protocol.GithubProtocol. Another third-party platform can be supported by implementing the AnotherProtocol class).

"1+n" protocol support: 1 for a common standard Webhook protocol, and n for special non-standard Webhook protocols. Users need to select a protocol in the source-config.yml.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia mentioned this issue Apr 30, 2024
Open
6 tasks
@Pil0tXia Pil0tXia changed the title Use the existing implementation of Webhook as an enhancement to the HTTP Source Connector, needs to be able to support the user's own implementation of a customized Webhook protocol. [Feature] Add Webhook support for HTTP Source Connector Apr 30, 2024
@Pil0tXia Pil0tXia mentioned this issue Apr 30, 2024
Merged
@Pil0tXia Pil0tXia added the help wanted Extra attention is needed label May 1, 2024
@cnzakii
Copy link
Contributor

cnzakii commented May 26, 2024

@Pil0tXia Please assign it to me

@cnzakii cnzakii mentioned this issue May 26, 2024
Merged
xwm1992 pushed a commit that referenced this issue Jun 27, 2024
@cnzakii
[ISSUE #4869] Add Webhook support for HTTP Source Connector (#4913)
996c439 
* feat: add webhook support

* feat: add CommonProtocol and optimize some logic

* doc: update some javaDoc

* fix: update something

* fix: Optimize queue related operations

* fix: Optimize queue related operations

* fix: Optimize queue related operations

* fix: update something

* fix: Remove some meaningless code

* fix: update something

* perf: Updates to protocol-related code, with a focus on request handling

* perf: use CircularFifoQueue

* perf: Use OkHttp Client to completely replace Apache Client and resolve code conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnzakii cnzakii

Labels
feature help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4869] Add Webhook support for HTTP Source Connector cnzakii/eventmesh
2 participants
@Pil0tXia @cnzakii