Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add JavaDoc for eventmesh-admin-rocketmq Module #4182

Closed
2 tasks done
Pil0tXia opened this issue Jul 4, 2023 · 1 comment · Fixed by #4183
Closed
2 tasks done

[Doc] Add JavaDoc for eventmesh-admin-rocketmq Module #4182

Pil0tXia opened this issue Jul 4, 2023 · 1 comment · Fixed by #4183
Labels
documentation Improvements or additions to documentation

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Jul 4, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Documentation Related

This is a subtask of GLCC Subject #4040.

Write comments for each method in the org.apache.eventmesh.admin.rocketmq package.

WIP.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Pil0tXia Pil0tXia added the documentation Improvements or additions to documentation label Jul 4, 2023
@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jul 4, 2023

Progress: https://github.com/Pil0tXia/eventmesh/commits/pil0txia_doc_4182

@Pil0tXia Pil0tXia changed the title [Doc] Add JavaDoc for eventmesh-admin Module [Doc] Add JavaDoc for eventmesh-admin-rocketmq Module Jul 5, 2023
@Pil0tXia Pil0tXia mentioned this issue Jul 5, 2023
Merged
xwm1992 pushed a commit that referenced this issue Jul 14, 2023
@Pil0tXia
[ISSUE #4182] Add JavaDoc and Comments for eventmesh-admin-rocketmq M…
d8b99af 
…odule (#4183)

* doc: Write JavaDoc and comments for AdminController

* doc: Write JavaDoc and comments for TopicsHandler

* doc: Write JavaDoc and comments for TopicCreateRequest

* doc: Write JavaDoc and comments for TopicResponse

* doc: Write JavaDoc and comments for RequestMapping

* doc: Write JavaDoc and comments for UrlMappingPattern

* doc: Update JavaDoc of ClientManageController#start

* chore: remove 1 old doc to solve the conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4182] Add JavaDoc and Comments for eventmesh-admin-rocketmq Module Pil0tXia/eventmesh
1 participant
@Pil0tXia