We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows
master
path is org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
i think this is a bug when i read code of master branch. This will cause the batch send of events to fail.
if (eventData != null || StringUtils.isBlank(batchId) || StringUtils.isBlank(producerGroup) || eventSize != eventList.size()) { responseEventMeshCommand = asyncContext.getRequest().createHttpCommandResponse( sendMessageBatchResponseHeader, SendMessageBatchResponseBody.buildBody(EventMeshRetCode.EVENTMESH_PROTOCOL_BODY_ERR.getRetCode(), EventMeshRetCode.EVENTMESH_PROTOCOL_BODY_ERR.getErrMsg())); asyncContext.onComplete(responseEventMeshCommand); return; }
The validation of eventData should be changed to '==null'.
eventData
just read the code
No response
The text was updated successfully, but these errors were encountered:
[ISSUE apache#3273] fix incorrect validation
f25041f
8917ab6
Merge pull request #3274 from epiao55/dev_fix_3273
adbe5ee
[ISSUE #3273] fix incorrect validation
epiao55
Successfully merging a pull request may close this issue.
Search before asking
Environment
Windows
EventMesh version
master
What happened
path is
org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
i think this is a bug when i read code of master branch. This will cause the batch send of events to fail.
The validation of
eventData
should be changed to '==null'.How to reproduce
just read the code
Debug logs
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: