Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Method check a map with containsKey(), before using get() [WebhookUtil] #2730

Closed
1 of 2 tasks
Alonexc opened this issue Dec 29, 2022 · 0 comments · Fixed by #2745
Closed
1 of 2 tasks
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Dec 29, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/WebhookUtil.java line 93
analysis and explanation:
This method checks for the presence of a key in a map using containsKey(), before attempting to fetch the value of the key using get(). This equates to doing two map lookups in a row.

Describe the solution you'd like

It is much simpler to just fetch the value with get, and checking for non null instead.
reference:
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Dec 29, 2022
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Dec 29, 2022
xwm1992 added a commit that referenced this issue Dec 31, 2022
[ISSUE #2730] Method check a map with containsKey(), before using get() [WebhookUtil]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants