Skip to content

Commit

Permalink
Merge pull request #2634 from jonyangx/issue2633
Browse files Browse the repository at this point in the history 
[ISSUE #2633] HttpUtils PMD check warning
  • Loading branch information
@xwm1992
xwm1992 authored Dec 26, 2022
2 parents a4eb9e6 + 3529558 commit 0d26e39
Showing 1 changed file with 35 additions and 41 deletions.
76 changes: 35 additions & 41 deletions eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/util/HttpUtils.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import org.apache.http.util.EntityUtils;

import java.io.IOException;
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
Expand All @@ -49,11 +48,11 @@
import lombok.extern.slf4j.Slf4j;

@Slf4j
public class HttpUtils {
public abstract class HttpUtils {

public static String post(CloseableHttpClient client,
String uri,
RequestParam requestParam) throws Exception {
public static String post(final CloseableHttpClient client,
final String uri,
final RequestParam requestParam) throws IOException {
final ResponseHolder responseHolder = new ResponseHolder();
final CountDownLatch countDownLatch = new CountDownLatch(1);
post(client, null, uri, requestParam, response -> {
Expand All @@ -75,10 +74,10 @@ public static String post(CloseableHttpClient client,
return responseHolder.response;
}

public static String post(CloseableHttpClient client,
HttpHost forwardAgent,
String uri,
RequestParam requestParam) throws Exception {
public static String post(final CloseableHttpClient client,
final HttpHost forwardAgent,
final String uri,
final RequestParam requestParam) throws IOException {
final ResponseHolder responseHolder = new ResponseHolder();
final CountDownLatch countDownLatch = new CountDownLatch(1);
post(client, forwardAgent, uri, requestParam, response -> {
Expand All @@ -100,37 +99,37 @@ public static String post(CloseableHttpClient client,
return responseHolder.response;
}

public static void post(CloseableHttpClient client,
HttpHost forwardAgent,
String uri,
RequestParam requestParam,
ResponseHandler<String> responseHandler) throws IOException {
public static void post(final CloseableHttpClient client,
final HttpHost forwardAgent,
final String uri,
final RequestParam requestParam,
final ResponseHandler<String> responseHandler) throws IOException {
Preconditions.checkState(client != null, "client can't be null");
Preconditions.checkState(StringUtils.isNotBlank(uri), "uri can't be null");
Preconditions.checkState(requestParam != null, "requestParam can't be null");
Preconditions.checkState(responseHandler != null, "responseHandler can't be null");
Preconditions.checkState(requestParam.getHttpMethod() == HttpMethod.POST, "invalid requestParam httpMethod");
Preconditions.checkState(requestParam.getHttpMethod().equals(HttpMethod.POST), "invalid requestParam httpMethod");

HttpPost httpPost = new HttpPost(uri);
final HttpPost httpPost = new HttpPost(uri);

//header
if (MapUtils.isNotEmpty(requestParam.getHeaders())) {
for (Map.Entry<String, String> entry : requestParam.getHeaders().entrySet()) {
for (final Map.Entry<String, String> entry : requestParam.getHeaders().entrySet()) {
httpPost.addHeader(entry.getKey(), entry.getValue());
}
}

//body
if (MapUtils.isNotEmpty(requestParam.getBody())) {
List<NameValuePair> pairs = new ArrayList<>();
for (Map.Entry<String, String> entry : requestParam.getBody().entrySet()) {
final List<NameValuePair> pairs = new ArrayList<>();
for (final Map.Entry<String, String> entry : requestParam.getBody().entrySet()) {
pairs.add(new BasicNameValuePair(entry.getKey(), entry.getValue()));
}
httpPost.setEntity(new UrlEncodedFormEntity(pairs, Constants.DEFAULT_CHARSET));
}

//ttl
RequestConfig.Builder configBuilder = RequestConfig.custom();
final RequestConfig.Builder configBuilder = RequestConfig.custom();
configBuilder.setSocketTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())))
.setConnectTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())))
.setConnectionRequestTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())));
Expand All @@ -148,32 +147,27 @@ public static void post(CloseableHttpClient client,
client.execute(httpPost, responseHandler);
}

public static void get(CloseableHttpClient client,
HttpHost forwardAgent,
String uri,
RequestParam requestParam,
ResponseHandler<String> responseHandler) throws Exception {
public static void get(final CloseableHttpClient client,
final HttpHost forwardAgent,
final String uri,
final RequestParam requestParam,
final ResponseHandler<String> responseHandler) throws IOException {
Preconditions.checkState(client != null, "client can't be null");
Preconditions.checkState(StringUtils.isNotBlank(uri), "uri can't be null");
Preconditions.checkState(requestParam != null, "requestParam can't be null");
Preconditions.checkState(requestParam.getHttpMethod() == HttpMethod.GET, "invalid requestParam httpMethod");
Preconditions.checkState(requestParam.getHttpMethod().equals(HttpMethod.GET), "invalid requestParam httpMethod");

//body
if (MapUtils.isNotEmpty(requestParam.getQueryParamsMap())) {
uri = uri + "?" + requestParam.getQueryParams();
}

HttpGet httpGet = new HttpGet(uri);
final HttpGet httpGet = new HttpGet(MapUtils.isNotEmpty(requestParam.getQueryParamsMap()) ? uri + "?" + requestParam.getQueryParams() : uri);

//header
if (MapUtils.isNotEmpty(requestParam.getHeaders())) {
for (Map.Entry<String, String> entry : requestParam.getHeaders().entrySet()) {
for (final Map.Entry<String, String> entry : requestParam.getHeaders().entrySet()) {
httpGet.addHeader(entry.getKey(), entry.getValue());
}
}

//ttl
RequestConfig.Builder configBuilder = RequestConfig.custom();
final RequestConfig.Builder configBuilder = RequestConfig.custom();
configBuilder.setSocketTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())))
.setConnectTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())))
.setConnectionRequestTimeout(Integer.parseInt(String.valueOf(requestParam.getTimeout())));
Expand All @@ -191,9 +185,9 @@ public static void get(CloseableHttpClient client,
client.execute(httpGet, responseHandler);
}

public static String get(CloseableHttpClient client,
String url,
RequestParam requestParam) throws Exception {
public static String get(final CloseableHttpClient client,
final String url,
final RequestParam requestParam) throws IOException {
final ResponseHolder responseHolder = new ResponseHolder();
final CountDownLatch countDownLatch = new CountDownLatch(1);
get(client, null, url, requestParam, response -> {
Expand All @@ -215,10 +209,10 @@ public static String get(CloseableHttpClient client,
return responseHolder.response;
}

public static String get(CloseableHttpClient client,
HttpHost forwardAgent,
String url,
RequestParam requestParam) throws Exception {
public static String get(final CloseableHttpClient client,
final HttpHost forwardAgent,
final String url,
final RequestParam requestParam) throws IOException {
final ResponseHolder responseHolder = new ResponseHolder();
final CountDownLatch countDownLatch = new CountDownLatch(1);
get(client, forwardAgent, url, requestParam, response -> {
Expand Down

0 comments on commit 0d26e39

Please sign in to comment.