Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): polar bar should update roundCap when changes #20567 #20582

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 12, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Update bar shape when roundCap changes.

Fixed issues

Details

Before: What was the problem?

When roundCap changes in later setOption, the bar shape doesn't change from sector to sausage shape.

After: How does it behave after the fixing?

Bar shape changes when roundCap updates.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 12, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20582@7eec3c4

@Ovilia Ovilia marked this pull request as ready for review December 13, 2024 06:20
@Ovilia Ovilia added this to the 6.0.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant