-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria): avoid throwing error in SSR mode #19892
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this PR as a temporary NPE fix. But we still need to support ARIA for SSR mode in the future.
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19892@872ac99 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Skip setting aria label attribute when in SSR mode.
Fixed issues
#19191:
Details
Before: What was the problem?
aria-label
was set on the DOM element, but in SSR there is no DOM element, so it would throw when enablingaria
orlocals
in options when using SSR, because thedom
variable in code isnull
.Also, this makes the last example in this release note (Two color locals) not working in SSR.
After: How does it behave after the fixing?
No aria label was added, but locals are working in SSR.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information