fix(toolbox): fix MouseEvent detection error
#19620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etect if `MouseEvent` object is supported (fix unexpected replacement in 53babd2#diff-0b91602cf047a98c67d6c4edaacbfa7399c8e0d2d4564b83ece8419d144aea84R64)
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
plainheart
changed the title
typeof operator rather than isFunction util to detect if MouseEvent object is supported ()typeof operator rather than isFunction util to detect if MouseEvent object is supported
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19620@385a817 |
Ovilia
approved these changes
Feb 20, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
changed the title
typeof operator rather than isFunction util to detect if MouseEvent object is supportedMouseEvent detection error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix an unexpected replacement in 53babd2#diff-0b91602cf047a98c67d6c4edaacbfa7399c8e0d2d4564b83ece8419d144aea84R64
- Should use the
typeofoperator to avoid uncaught reference error.Fixed issues
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information