fix(ssr): remove redundant SVG attributes with undefined
value
#19461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
#18381 set some required metadata for SVG elements but it didn't skip the undefined values, which caused the chart to generate many redundant attributes with the 'undefined' value.
In this PR, I add a precheck for
dataIndex
. It will skip to set SSR data if thedataIndex
is not present.Also, I fixed an unexpected assignment:
Besides, I also added a non-null check in zrender. Please refer to ecomfe/zrender#1048.
Fixed issues
#18381
Comparison
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to
test/svg-ssr.html
.Others
Merging options
Other information