fix(scatter): fix edge scatter may be unexpectedly clipped due to tiny offset #18867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y offset. - add the `tolerance` parameter for `CoordinateSystem#getArea`. - set the default tolerance of the scatter series as `1e-2`
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18867@65717db |
pissang
approved these changes
Jul 9, 2023
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the scatters near the edge of the coordinate system grid may be unexpectedly clipped due to a tiny offset.
tolerancefor theCoordinateSystem#getAreamethod.0.1(Got by test, it should cover more scenarios than1e-2)Similar to PR #16329.
Fixed issues
Comparison
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to
test/clip2.html.Others
Merging options
Other information
The bar series has the same bug. See also #16666. It can be fixed in another PR later.