Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(treemap): add scaleLimit to limit the zooming #17602

Closed
wants to merge 1 commit into from

Conversation

kerorojason
Copy link

@kerorojason kerorojason commented Aug 31, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add scaleLimit option to allow limiting the zooming in treemap.

Fixed issues

Details

Before: What was the problem?

We don't have any limitation for zooming in treemap.

After: How does it behave after the fixing?

Support scaleLimit in treemap series, as graph series, tree series, geo component did.

Like scaleLimit in geo

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 31, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the way with other series or components (like Graph, Tree, Geo). You may search for scaleLimit to learn more.
Please also provide a test file with npm run mktest "treemap-scaleLimit".

@plainheart plainheart changed the title add scaleLimit to treemap feat(treemap): add scaleLimit to limit the zooming Sep 26, 2022
@dannishushu
Copy link

@kerorojason Has this commit been merged into the release branch?

@Ovilia
Copy link
Contributor

Ovilia commented Jun 11, 2024

@kerorojason Has this commit been merged into the release branch?

This feature is supported in #18304 and is expected to be released in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: first-time contributor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants